Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stage cdn url for tvm stage #90

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Use stage cdn url for tvm stage #90

merged 4 commits into from
Apr 8, 2021

Conversation

Himavanth
Copy link
Contributor

@Himavanth Himavanth commented Mar 15, 2021

Description

Related Issue

[ACNA-1115]

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #90 (200856c) into master (51b88d8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 200856c differs from pull request most recent head d795f47. Consider uploading reports for the commit d795f47 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          542       546    +4     
  Branches        94        95    +1     
=========================================
+ Hits           542       546    +4     
Impacted Files Coverage Δ
lib/impl/AzureBlobFiles.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b88d8...d795f47. Read the comment docs.

@Himavanth Himavanth marked this pull request as ready for review April 5, 2021 08:52
@Himavanth
Copy link
Contributor Author

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Himavanth Himavanth merged commit 386ecd8 into master Apr 8, 2021
@Himavanth Himavanth deleted the stage branch April 8, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants