Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presigned urls don't work if user provided its own azure credentials and init might break #52

Closed
moritzraho opened this issue Aug 14, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@moritzraho
Copy link
Member

Expected Behaviour

  • files.init({ azure: { <with SAS urls> } } should throw a clear error when using files.generatePresignURL as there is no way to generate pre signed urls without valid access to the tvm or storage account credentials
  • files.init({ azure: { <with storage account credentials> } }) should be able to generate presigned url using its own storage account credentials in the same way the TVM would do it when initializing the files sdk with OpenWhisk credentials

Actual Behaviour

  • files.init({ azure: { <with SAS urls> } }) in a runtime action: initializes the tvm while it shouldn't and when using files.generatePresignURL fails with a cryptic error message as it attempts to generate a presign url using the TVM from a blob not managed by the TVM storage account
  • files.init({ azure: { <with SAS urls> } }) outside a runtime action: breaks directly on init as it attempts to init the TVM without any OpenWhisk credentials

Same for files.init({azure: { <with storage account credentials>}}) while in that case we should be able to support pre-signed urls

@moritzraho moritzraho changed the title Presigned urls don't work if user provided its own azure credentials and might break init Presigned urls don't work if user provided its own azure credentials and init might break Aug 14, 2020
@moritzraho moritzraho added the bug Something isn't working label Aug 14, 2020
@aiojbot
Copy link
Collaborator

aiojbot commented Aug 14, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants