Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1147 - better error message for context token generation #70

Merged
merged 1 commit into from
May 11, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented May 10, 2021

Description

Depends on adobe/aio-lib-ims-jwt#25
Depends on adobe/aio-lib-ims-oauth#30

Related Issue

Fixes #69

Motivation and Context

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member Author

shazron commented May 10, 2021

Re-run the tests once the two associated PRs have been released.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #70 (f5ce8b5) into master (95a0787) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          386       391    +5     
  Branches        48        49    +1     
=========================================
+ Hits           386       391    +5     
Impacted Files Coverage Δ
src/token-helper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a0787...f5ce8b5. Read the comment docs.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shazron shazron merged commit d7e7476 into master May 11, 2021
@shazron shazron deleted the ACNA-1147 branch May 11, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better error message for context token generation
2 participants