Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breaking-change): ACNA-2584 - add Adobe App Builder State Store #135

Merged
merged 21 commits into from
Jan 30, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 9, 2024

This is a breaking change. The CosmosDB State Store has been removed, and we will be using our own State Store.
Note for put, the new restriction is we can only push strings, not any other types like objects.

The change has been designed to be "drop in" for existing users, so they won't need to change their code except if they have been pushing non-string data to the state store, they will have to stringify their values now.

How Has This Been Tested?

  • npm test
  • e2e tests (using the adp-state-storage local server)

MERGING NOTES (DO NOT MERGE UNTIL COMPLETED)

  • The prod and stage endpoints have not been finalized, there are placeholder urls in lib/constants.js
  • [ ] The Adobe AB State Store has been released to production the main branch is the aio-lib-state next release. The old release is in the 2.x branch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef5aa34) 100.00% compared to head (7cf0bf1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          173       165    -8     
  Branches        36        29    -7     
=========================================
- Hits           173       165    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member Author

shazron commented Jan 26, 2024

wait for #136

@shazron shazron merged commit 1eee5df into master Jan 30, 2024
7 checks passed
@shazron shazron deleted the story/ACNA-2584 branch January 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants