-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breaking-change): ACNA-2584 - add Adobe App Builder State Store #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 173 165 -8
Branches 36 29 -7
=========================================
- Hits 173 165 -8 ☔ View full report in Codecov by Sentry. |
|
12 tasks
moritzraho
approved these changes
Jan 30, 2024
amulyakashyap09
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change. The CosmosDB State Store has been removed, and we will be using our own State Store.
Note for
put
, the new restriction is we can only push strings, not any other types like objects.The change has been designed to be "drop in" for existing users, so they won't need to change their code except if they have been pushing non-string data to the state store, they will have to stringify their values now.
How Has This Been Tested?
MERGING NOTES (DO NOT MERGE UNTIL COMPLETED)
lib/constants.js
[ ] The Adobe AB State Store has been released to productionthe main branch is the aio-lib-statenext
release. The old release is in the2.x
branchTypes of changes
Checklist: