parcel v1 to v2 migration #150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 166 163 -3
Branches 39 39
=========================================
- Hits 166 163 -3
Continue to review full report at Codecov.
|
|
|
||
| const cleanup = async () => { | ||
| aioLogger.debug('cleanup bundler...') | ||
| await bundler.stop() |
There was a problem hiding this comment.
I guess this needs to be replaced with onBuildEnd event from the bundler for the cleanup.
There was a problem hiding this comment.
For the onBuildEnd of Parcel V1, we have reporter plugin in V2. But i think it's different from the stop API. This event handler is to see what assets were built but not for cleanup.
src/bundle.js
Outdated
| defaultConfig: require.resolve('@parcel/config-default'), | ||
| shouldDisableCache: false, | ||
| targets: { | ||
| action: { |
There was a problem hiding this comment.
why action is it some parcel jargon or you choose the target key ?
There was a problem hiding this comment.
It can be anything.
There was a problem hiding this comment.
ok should we use web-assets key instead ?
|
@Himavanth when trying to provide my custom parcel config with My config looks like this: Do you know if I'm doing something wrong ? Or is it not possible anymore to provide a custom parcel config ? |
|
There is some mismatch in the latest tags of parcel and the associated npm packages. Parcel has beta.2 as latest but parcel/config-default has alpha.3. |
|
@Himavanth I noticed the |
|
@icaraps good point. I will add it. |
Description
TODO
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: