Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: added the videocarousel #1500

Merged
merged 5 commits into from
May 2, 2023
Merged

build: added the videocarousel #1500

merged 5 commits into from
May 2, 2023

Conversation

BaskarMitrah
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkim
Copy link
Collaborator

timkim commented Apr 25, 2023

Hey @BaskarMitrah this is looking good but I am noticing there are some margin issues with the left arrow button. It seems to overlap the text of the main body. Can we add some padding/margins so that it doesn't overlap?
Screenshot 2023-04-25 at 1 33 57 PM

@BaskarMitrah
Copy link
Collaborator Author

@timkim Added padding on the left arrow button. Seem now it's looking fine
image

@timkim
Copy link
Collaborator

timkim commented May 2, 2023

lgtm. Thanks @BaskarMitrah

@timkim timkim merged commit 7d87d97 into main May 2, 2023
@timkim timkim deleted the videoCarousel branch May 2, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants