-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox updates #1099
base: main
Are you sure you want to change the base?
Sandbox updates #1099
Conversation
Note that this includes all the changes from #1087. Not sure if that was intentional or not |
d23a4c7
to
683493d
Compare
683493d
to
5d9a91c
Compare
a2372ac
to
9bdf4b7
Compare
While testing the custom build script, our current sandbox was running on deprecated npm packages that required updates. Deployed it to alloyio.com to test. Once approved, I'll rebase the changes to custom build branch. |
@carterworks can you please review the PR? @ninaceban do you see any breaking changes to target? |
sandbox/public/index.css
Outdated
color: #acecfe; | ||
} | ||
monospace; | ||
color: #acecfe; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the color darker to be more readable on a white background.
color: #eaeaea; | ||
} | ||
|
||
a { | ||
color: #e7ca8d; | ||
nav { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please make the left nav a little wider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great start and initiative.
I would like us to make the following updates:
- Use the Unified JS Lab and not the. QE Org
- Fix all the Personalization pages
@jfkhoury Refactored tags to use the corresponding React Spectrum components. Fixed the coloring and added support for responsiveness. |
d7b17ef
to
a321aec
Compare
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: