Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of general improvements #48

Closed
sparshev opened this issue Apr 8, 2023 · 0 comments · Fixed by #49
Closed

A couple of general improvements #48

sparshev opened this issue Apr 8, 2023 · 0 comments · Fixed by #49
Assignees
@sparshev
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@sparshev
Copy link
Collaborator

sparshev commented Apr 8, 2023

So, there is a couple of good things is missing, which will be great to add:

  • Maintenance / Shutdown of the node - we need an API call to request the node to stop executing incoming workloads and another one to shutdown when it's safe. This will allow for simple cluster support and automatic update of the fish node to the never version.
  • YAML in Label definitions - no comments and those commas, do we really need them here? It will be much easier to define labels in yaml for the end user.
@sparshev sparshev added the enhancement New feature or request label Apr 8, 2023
@sparshev sparshev added this to the v1.0.0 milestone Apr 8, 2023
@sparshev sparshev self-assigned this Apr 8, 2023
@sparshev sparshev mentioned this issue Apr 11, 2023
Merged
10 tasks
@sparshev sparshev mentioned this issue Apr 16, 2023
Merged
10 tasks
sparshev added a commit that referenced this issue Apr 16, 2023
@sparshev
Added native driver and redesigned the image management logic (#46)
169c4ac 
Besides adding the new Native driver for MacOS this change also changes the image definition process of the VMX and Docker drivers.

* Native driver was added! It's as usual supports only macos for now, but adding to the other systems should not be so hard. It uses the node description to get the identifiers (configurable) which should be used by the Labels to find the appropriate fish node to execute on.
* **BREAKING**: VMX and Docker now uses a bit different way to specify the Label definition images, so the Labels need to be updated. But as an advantage now it supports checksum to verify the image!
* Added node filter and node identifiers for easy selecting where to execute the workload. It's common for all the drivers so can be used for VMX to run macos on macos or to run arm64 on arm64.
* Switched examples to YAML representation - now it's readability is better
* A number of fixes:
   * Fixed AWS startup issue - messed up gt with lt as usual
   * Replaced ioutil usage since deprecated as of go v1.16
   * Replaced all `interface{}` to `any`
   * Fixed YAML user interface introduced in #48 - now it properly handled
   * Added UID references validation, previously they was handled automatically but after migration from dqlite that was lost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparshev sparshev

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

YAML support, Maintenance/Shutdown API and updated dependencies adobe/aquarium-fish
1 participant
@sparshev