Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added native driver and redesigned the image management logic #46

Merged
merged 18 commits into from
Apr 16, 2023
Merged

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Mar 13, 2023

Besides adding the new Native driver for MacOS this change also changes the image definition process of the VMX and Docker drivers.

  • Native driver was added! It's as usual supports only macos for now, but adding to the other systems should not be so hard. It uses the node description to get the identifiers (configurable) which should be used by the Labels to find the appropriate fish node to execute on.
  • BREAKING: VMX and Docker now uses a bit different way to specify the Label definition images, so the Labels need to be updated. But as an advantage now it supports checksum to verify the image!
  • Added node filter and node identifiers for easy selecting where to execute the workload. It's common for all the drivers so can be used for VMX to run macos on macos or to run arm64 on arm64.
  • Switched examples to YAML representation - now it's readability is better
  • A number of fixes:
    • Fixed AWS startup issue - messed up gt with lt as usual
    • Replaced ioutil usage since deprecated as of go v1.16
    • Replaced all interface{} to any
    • Fixed YAML user interface introduced in A couple of general improvements #48 - now it properly handled
    • Added UID references validation, previously they was handled automatically but after migration from dqlite that was lost

Related Issue

closes: #2
related: adobe/aquarium-bait#4

How Has This Been Tested?

Automatically, Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the enhancement New feature or request label Mar 13, 2023
@sparshev sparshev self-assigned this Mar 13, 2023
@sparshev sparshev force-pushed the AF-2 branch 2 times, most recently from 9992d2c to 850fdf1 Compare March 14, 2023 06:09
* AWS/Docker/VMX images descriptions was unified and checksum was added for verification
* Added node to the driver Prepare since needed further
@sparshev sparshev added the bug Something isn't working label Apr 16, 2023
@sparshev sparshev merged commit 169c4ac into main Apr 16, 2023
@sparshev sparshev deleted the AF-2 branch April 16, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native driver implementation
1 participant