Linux Sprint 29 #297

jasonsanjose · 2013-08-13T17:07:20Z

Replaces scripts/setup_linux_build.sh.

RUN npm install on this branch to update the new dependency on semver.

@timburgess @DaBungalow would you like to test out these updates? Someone else with committer rights will need to handle merging though.

These changes bring the Linux setup and build Grunt tasks up to par with mac and windows. This doesn't replace the one-line wget (see https://gist.github.com/jasonsanjose/5514813) required for downloading the git repositories and installing Node.js and Grunt.

Here are the highlights:

CEF binaries are now hosted at http://dev.brackets.io. These binaries are modified from the original zip files. To reduce the download size, I've removed the Debug folder. For folks like @timburgess that are doing work with the native shell, it won't be too hard for them to get the full binaries manually.
There's some extra commits from another outstanding pull fetch origin for new branches. fix jshint errors. #286. The prior pull should be merged first.
CEF and Node.js downloads are supported for 32 and 64 bit. I haven't tested the build process on 64-bit yet.
Speaking of build, you should be able to just pull this branch and run grunt to setup and build. grunt installer will produce the debian package
There's a new postinstall hook after npm install to install the compile-time dependencies
Incremental linux builds can be done via grunt build or simply make as before
Use a template DEBIAN\control file and populate dynamically with brackets version, arch and installed size. See Lintian error: Split linux debian installer CONTROL file for 32 and 64 bit brackets#4724.

use correct fs.symlink on mac and linux add arch support for linux 64-bit update grunt tasks for linux add linux installer to grunt tasks fix linux clean installer task update grunt for node on linux. move linux tools to an npm postinstall script. rename debian package to Brackets Sprint NN.deb fix 64 bit build update debian package version and 64-bit dep

…x-sprint-28

…pendencies via their package managerprior to running grunt build

…be/brackets-shell into jasonsanjose/linux-sprint-29 Conflicts: installer/linux/build_installer.sh

JeffryBooher · 2013-08-16T00:30:04Z

Gruntfile.js

@@ -114,7 +126,7 @@ module.exports = function (grunt) {
                "files": [
                    {
                        "expand"    : true,
-                        "cwd"       : "out/Release",
+                        "cwd"       : "out/Release/",


@jasonsanjose what's the significance of this change? I noticed that we mostly put the trailing slash on directory names but there are a few instances where we don't. Just curious.

Just for consistency. I thought this was the last oddball. Was there more?

At least 4 other places have directory names that do not end in a forward slash. Probably not a big deal -- I was just curious if Linux had some special requirement.

JeffryBooher · 2013-08-16T00:56:03Z

I got an error running grunt on Windows "ERROR: Cannot find module 'semver'" but grunt continues and finishes the build. Haven't tried Mac yet.

JeffryBooher · 2013-08-16T06:58:02Z

Same error on Mac

Conflicts: Gruntfile.js

jasonsanjose · 2013-08-16T17:42:48Z

Updated the pull request description to run npm install to get semver. This will fix the build error on windows.

jasonsanjose · 2013-08-16T17:51:38Z

installer/linux/debian/package-root/DEBIAN/prerm

@@ -0,0 +1,39 @@
+#!/bin/sh
+#
+# Copyright (c) 2009 The Chromium Authors. All rights reserved.


Need to add to 3rd party code

Do we need to wait for legal before merging?

I'll ping @julianasuh. The source is from Chromium's debian packaging scripts here http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/linux/.

JeffryBooher · 2013-08-16T18:12:58Z

Windows now builds without error

…it linux due to missing 3.1547.1354 binary.

…obe/brackets-shell into jasonsanjose/linux-sprint-29

timburgess · 2013-08-19T08:10:37Z

No problem with the npm install but I'm failing on the cef-download task with a connect ETIMEDOUT Looks like dev.brackets.io on github is not available(?). My ICMP roundtrips are good everywhere else. Will try again tomorrow AM.

jasonsanjose · 2013-08-19T20:44:08Z

@timburgess downloads are fixed now. @adrocknaphobia thinks it could have been a bot.

Anyway, @JeffryBooher pointed out 2 issues over email that I've filed. We can fix these separately from this pull request:

Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env brackets#4828 Symlink libudev for developer environment setup
Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env brackets#4828 Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env

timburgess · 2013-08-19T21:23:15Z

Yup, I can see dev.brackets.io now. The same as master, the CEF version for cef-linux64 has bumped to 3.1547.1354 yet there is no cef_binary_3.1547.1354 on dev.brackets.io/cef so the cef task fails on 64-bit Linux.

I see also that cef-linux32 has CEF 3.1547.1357 hardwired & that is not present on dev.brackets.io/cef either.
Should they both be 3.1547.1357?

I've been working on Linux with prior CEF builds I did myself. Will see if I can get a CEF 3.1547.1357 build via chromium & if so, then can at least test the latter stages too.

timburgess · 2013-08-19T21:25:37Z

Ah, missed the comment - ignore the CEF 32bit vs 64bit version question.

jasonsanjose · 2013-08-19T21:38:30Z

@timburgess yep we had to hardcode the 32-bit binary since build 1354 wasn't built. This is just temporary until we make our next CEF upgrade.

The zips were just pushed to dev.brackets.io/cef. You can try that out now.

timburgess · 2013-08-19T22:21:10Z

Lovely! Works for me but I had a couple of hitches:

I had a couple of older cef zips in downloads. This was causing cef-download to skip however cef-extract failed on extract because the required version wasn't there
zip file produces a __MACOSX in deps/ and there is a .DS_Store in deps/cef - the binary build still works however and seems perfectly fine with brackets/master at present

and to clarify, this is on Ubuntu 12.04 64bit

JeffryBooher · 2013-08-19T23:08:06Z

Looks like everything is good to go -- just waiting to hear back from legal on the 3rd party code.

JeffryBooher · 2013-08-20T00:46:54Z

Got clearance from legal...Merging

Linux Sprint 29

jasonsanjose added 8 commits July 30, 2013 09:47

update build num

1437f4a

fix postinstall grunt task

65e08d6

update CEF URLs for linux

8bf61ee

Merge remote-tracking branch 'upstream/master' into jasonsanjose/linu…

b3cef2c

…x-sprint-28

move debian package files

b0434f4

create template control file for debian package

d4df304

round up file size in debian control

7cfb83b

ghost assigned jeffkenton and JeffryBooher Aug 13, 2013

jasonsanjose added 7 commits August 13, 2013 16:57

remove preinstall.sh. requires devs now to manually install system de…

1cf8540

…pendencies via their package managerprior to running grunt build

use google-chrome debian package scripts

6d1e827

fix brackets icon

926a034

fix brackets icon

0c765de

Merge branch 'jasonsanjose/linux-sprint-29' of https://github.com/ado…

fd764c2

…be/brackets-shell into jasonsanjose/linux-sprint-29 Conflicts: installer/linux/build_installer.sh

fix 32-bit detect of libudev

0b42574

fix jshint error

6fba31a

JeffryBooher reviewed Aug 16, 2013
View reviewed changes

Merge branch 'master' into jasonsanjose/linux-sprint-29

bea3856

Conflicts: Gruntfile.js

jasonsanjose reviewed Aug 16, 2013
View reviewed changes

jasonsanjose added 2 commits August 16, 2013 11:53

add missing license to Chromium installer file. hardcode CEF for 32-b…

fb61d52

…it linux due to missing 3.1547.1354 binary.

:Merge branch 'jasonsanjose/linux-sprint-29' of https://github.com/ad…

3c9610b

…obe/brackets-shell into jasonsanjose/linux-sprint-29

JeffryBooher added a commit that referenced this pull request Aug 20, 2013

Merge pull request #297 from adobe/jasonsanjose/linux-sprint-29

5fa26db

Linux Sprint 29

JeffryBooher merged commit 5fa26db into master Aug 20, 2013

JeffryBooher deleted the jasonsanjose/linux-sprint-29 branch August 20, 2013 00:47

jasonsanjose mentioned this pull request Aug 20, 2013

fetch origin for new branches. fix jshint errors. #286

Closed

JeffryBooher added a commit that referenced this pull request Dec 8, 2015

Merge pull request #297 from adobe/jasonsanjose/linux-sprint-29

99c98ee

Linux Sprint 29

This was referenced Aug 17, 2021

[CLOSED] fetch origin for new branches. fix jshint errors. brackets-archive/brackets-shell#177

Open

[CLOSED] Linux Sprint 29 brackets-archive/brackets-shell#184

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux Sprint 29 #297

Linux Sprint 29 #297

jasonsanjose commented Aug 13, 2013

JeffryBooher Aug 16, 2013

jasonsanjose Aug 16, 2013

JeffryBooher Aug 16, 2013

JeffryBooher commented Aug 16, 2013

JeffryBooher commented Aug 16, 2013

jasonsanjose commented Aug 16, 2013

jasonsanjose Aug 16, 2013

JeffryBooher Aug 16, 2013

jasonsanjose Aug 16, 2013

JeffryBooher commented Aug 16, 2013

timburgess commented Aug 19, 2013

jasonsanjose commented Aug 19, 2013

timburgess commented Aug 19, 2013

timburgess commented Aug 19, 2013

jasonsanjose commented Aug 19, 2013

timburgess commented Aug 19, 2013

JeffryBooher commented Aug 19, 2013

JeffryBooher commented Aug 20, 2013

Linux Sprint 29 #297

Linux Sprint 29 #297

Conversation

jasonsanjose commented Aug 13, 2013

JeffryBooher Aug 16, 2013

Choose a reason for hiding this comment

jasonsanjose Aug 16, 2013

Choose a reason for hiding this comment

JeffryBooher Aug 16, 2013

Choose a reason for hiding this comment

JeffryBooher commented Aug 16, 2013

JeffryBooher commented Aug 16, 2013

jasonsanjose commented Aug 16, 2013

jasonsanjose Aug 16, 2013

Choose a reason for hiding this comment

JeffryBooher Aug 16, 2013

Choose a reason for hiding this comment

jasonsanjose Aug 16, 2013

Choose a reason for hiding this comment

JeffryBooher commented Aug 16, 2013

timburgess commented Aug 19, 2013

jasonsanjose commented Aug 19, 2013

timburgess commented Aug 19, 2013

timburgess commented Aug 19, 2013

jasonsanjose commented Aug 19, 2013

timburgess commented Aug 19, 2013

JeffryBooher commented Aug 19, 2013

JeffryBooher commented Aug 20, 2013