Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix linux runtime dependency installation #305

Merged
merged 3 commits into from
Aug 21, 2013

Conversation

jasonsanjose
Copy link
Member

Fix for adobe/brackets#4720

  • Copies chromium install scripts to symlink libudev, libnss3 and libnspr4 locally into /opt/brackets/ then set LD_LIBRARY_PATH to use the symlinked libraries
  • Creates a new brackets wrapper script that is copied to the staging folder pacakge-root/opt/brackets
  • Creates a new symlink /usr/bin/brackets to point to /opt/brackets/brackets
  • Update dependencies to match google-chrome 28

I've uploaded a 64-bit package for testing here https://github.com/jasonsanjose/brackets-shell/releases/tag/0.30.0-8781. I tested this on a clean ubuntu 13.04 64-bit VM and did not get any libudev or libplc errors.

@jasonsanjose
Copy link
Member Author

Tagging @JeffryBooher @redmunds @timburgess @dabungalow to help test.

@thefirstofthe300
Copy link

I installed the linked package but ended up with this error when running brackets.

brackets: libcef_dll/wrapper/libcef_dll_wrapper.cc:121: int CefExecuteProcess(const CefMainArgs&, CefRefPtr<CefApp>): Assertion `false' failed. 
Aborted

It doesn't seem to be related to the dependencies.

@tttzof351
Copy link

The same thing

brackets: libcef_dll/wrapper/libcef_dll_wrapper.cc:121: int CefExecuteProcess(const CefMainArgs&, CefRefPtr): Assertion `false' failed.
Aborted (core dumped)

@jasonsanjose
Copy link
Member Author

Thanks @DaBungalow and @tttzof351 I'll take a look. It could be the new CEF.

@jasonsanjose
Copy link
Member Author

Yep. Something got wedged in my build. I did a clean build and everything is working (and tested this time). I've updated the .deb at the link above.

@ghost ghost assigned JeffryBooher Aug 20, 2013
@thefirstofthe300
Copy link

Upon downloading the clean build and on a fresh install of Linux Mint 15, everything works out of the box.

I did some poking around in the file system and didn't find a symlink from libudev.so.0 to libudev.so.1, which seems odd considering everything is working just fine.

@thefirstofthe300
Copy link

Ignore my last comment. I found the symlinks. sheepish grin

@jasonsanjose
Copy link
Member Author

@JeffryBooher, we got feedback from @DaBungalow at least. Want to start the review now or wait for @timburgess too?

@ghetolay
Copy link

Hi,

I'm just testing brackets on ubuntu 13.04. Sprint 29 didn't work but this one works great :)
Now I'm unable to install plugins but that's another story.

@TomMalbran
Copy link

@ghetolay Test with PR #306 which has this PR and Node.js integrated. So it should let you install plugins too :)

@jasonsanjose
Copy link
Member Author

@ghetolay I'm uploading an updated .deb file there now. Give it another 10 min.

@timburgess
Copy link
Contributor

Installed the .deb on a 'fresh' Ubuntu 12.04 LTS 64bit machine which hasn't had any Brackets dev done on it beforehand. .deb installs and /opt/brackets/Brackets runs as expected. Only question I have is that there is a Brackets and a brackets in /opt/brackets, both with executable permissions - not sure why that is the case.

@jasonsanjose
Copy link
Member Author

@timburgess because that's what Chrome does. :)

Brackets is a binary executable and brackets is a shell script to wrap Brackets in order to set the LD_LIBRARY_PATH.

@JeffryBooher
Copy link
Contributor

Installed and played with it for an afternoon without any problems.

My only concerns are:

  1. The debian package seems to be missing some information such as license. It should say "MIT"
  2. Brackets does not show up for me in the "Ubuntu Software Center". This feels like a must have as usr/share/applications is a little tough to navigate to and we should show it under installed applications if the "Ubuntu Software Center" is used to install it.
  3. The installed version does not have tests enabled. Not sure if we should do this but, since this is a new OS, we should consider enabling and shipping unit tests with the debian package for a while. Just until we have 100% functionality across the board or we get the error -3 taken care of.

@JeffryBooher
Copy link
Contributor

@jasonsanjose I think this is good to go. Just need @timburgess and @DaBungalow to sign off on it and I'll do the merge.

@thefirstofthe300
Copy link

I say go for it.

On Tue, Aug 20, 2013 at 5:46 PM, Jeff Booher notifications@github.comwrote:

@jasonsanjose https://github.com/jasonsanjose I think this is good to
go. Just need @timburgess https://github.com/timburgess and @DaBungalowhttps://github.com/DaBungalowto sign off on it and I'll do the merge.


Reply to this email directly or view it on GitHubhttps://github.com//pull/305#issuecomment-22988575
.

Danny Seymour
dannyseeless@gmail.com

@JeffryBooher
Copy link
Contributor

@jasonsanjose hold the phone... I just got a WSOD on Linux and I wasn't doing anything... I wasn't even using that computer...

@JeffryBooher
Copy link
Contributor

Merging

JeffryBooher added a commit that referenced this pull request Aug 21, 2013
Fix linux runtime dependency installation
@JeffryBooher JeffryBooher merged commit 914e5e3 into master Aug 21, 2013
@JeffryBooher JeffryBooher deleted the jasonsanjose/linux-sprint-29 branch August 21, 2013 01:00
@jasonsanjose
Copy link
Member Author

@JeffryBooher

  1. There is more to do here with the metadata. A copyright file should be easy. There's a task here https://trello.com/c/ZoCPy6mD/895-linux-ubuntu-installer-packaging.
  2. Ubuntu Software Center is likely a completely different beast. I'm not sure why it doesn't show up as installed. I don't see chrome there either. Maybe it only shows packages that USC hosts itself?
  3. We don't show tests for installed builds on mac or win either. Users have to run tools/setup_for_hacking.sh in order to point to the git repo.

JeffryBooher added a commit that referenced this pull request Dec 8, 2015
Fix linux runtime dependency installation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants