This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Use stat on file systems that do not support d_type in file entry record returned from readdir. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystems that do not support d_type.
|
@RaymondLim which filesystem doesn't support d_type? I'd like to test and verify your PR. Thank you. |
|
REISERFS https://github.com/adobe/brackets/issues/#5758 and SSHFS https://github.com/adobe/brackets/issues/#5544. Not sure how you're going to test with these filesystems. But you can always test with your existing filesystem by commenting out the original code and just use the new call stat for all file entries. Update: http://en.wikipedia.org/wiki/Category:Linux_file_systems lists all the available file systems for Linux. Not sure what file systems are used for those reporting in adobe/brackets#5292. |
ghost
assigned
ingorichter
added a commit
that referenced
this pull request
Nov 6, 2013
Use stat on file systems that do not support d_type in file entry record returned from readdir.
|
Looks good. Thank you. |
ingorichter
added a commit
that referenced
this pull request
Dec 8, 2015
Use stat on file systems that do not support d_type in file entry record returned from readdir.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes adobe/brackets#5292.