Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Support Auto Hide Task Bars on Windows #474

Merged
merged 4 commits into from
Oct 16, 2014
Merged

Conversation

JeffryBooher
Copy link
Contributor

This is for: adobe/brackets#7555
This replaces: #471

  • Testing recommendations:

Place the task bar on:

  1. Left
  2. Top
  3. Bottom
  4. Right

Test with both auto hide and always visible.

This should be checked on Multiple Monitors as a fair amount of work went in to finding the right solution for multiple monitors.

  • Make sure the Maximized size on a monitor without a task bar is the whole monitor
  • Make sure the Maximized size on a monitor with a task bar that is not auto-hide works (top/left/bottom/right)
  • Make sure that the Maximized size on both monitors is respected if the task bar is shown on all monitors (left/top/bottom/right)
  • Make sure that the window adjusts itself when the app bar position or auto-hide flag changes while the app is running.
  • Make sure that the size placement accommodates for a hidden Windows task bar if its state was not hidden when brackets saved the window placement data and is restarted with a hidden windows taskbar
  • Make sure the app adjusts itself when changing the placement of the taskbar
  • Make sure the app adjusts itself when changing the auto-hide state

You will notice a 1px area between the app and the taskbar. This is the taskbar and typical of all apps to give the taskbar an edge to grab. It IS more apparent with a dark border which gives the 1px line a little more contrast and makes it more visible.

@JeffryBooher
Copy link
Contributor Author

@redmunds squashed and ready for merging. Thanks for the review!

rect.bottom = rect.top + ::GetSystemMetrics(SM_CYSMICON);
rect.right = rect.left + ::GetSystemMetrics(SM_CXSMICON);

AdjustRectForAutoHideBars(&rect);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing this line indented with spaces and the rest of the function is indented with Tabs. I know there's a mix of spaces vs tabs in code base, and even in some files, but I think it should at least be consistent in each function/method.

@redmunds
Copy link
Contributor

Sorry, for already saying it was ok to squash, but I realized that I didn't try all of the testing recommendations and I now notice a nasty bug:

  1. Set taskbar on primary monitor (either show or auto-hide)
  2. Drag Brackets window to secondary monitor and Maxmize

Results
Window is not correctly sized. Top and left are correct, but height is really short (~100px) and width is too wide. Upper-right buttons are off the screen -- need to double-click on header to Restore window.

UPDATE: This seems to be related to my secondary monitor setup (it's above primary). If I move secondary monitor to the right of primary and problem goes away. See screen shot for my setup:

screen-resolution

Primary monitor resolution is 1920x1200

@redmunds
Copy link
Contributor

@JeffryBooher I fixed the whitespace: 10e1378

@redmunds
Copy link
Contributor

Merging.

redmunds added a commit that referenced this pull request Oct 16, 2014
Support Auto Hide Task Bars on Windows
@redmunds redmunds merged commit 59a44cb into master Oct 16, 2014
@redmunds redmunds deleted the jeff/fix-7555-final branch October 16, 2014 18:51
@JeffryBooher
Copy link
Contributor Author

@redmunds thanks for the review!

redmunds added a commit that referenced this pull request Dec 8, 2015
Support Auto Hide Task Bars on Windows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants