This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Support AppGetChromeVersionString and AppGetProductVersionString on Linux #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inux. AppGetProductVersionString uses a newly created version_linux.h file including only a APP_VERSION constant as there seems to be no other way to retrieve version number on Linux. The functions work, but unfortunately the user agent string (navigator.userAgent) doesn't yet contain these strings as there seems to be something wrong with the way settings.product_version is set in cefclient.cpp
marcelgerber
force-pushed
the
linux-chrome-version-string
branch
from
70ecc6a
to
e4ec166
Compare
|
It seems to me that the only purpose of |
|
Now these methods are in |
|
With #591 now this is on master. As I said I don't believe this is worth on linux-1547 branch so closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppGetProductVersionStringuses a newly createdversion_linux.hfile including only aAPP_VERSIONconstant as there seems to be no other way to retrieve version number on Linux.The functions work, but unfortunately the user agent string (
navigator.userAgent) doesn't yet contain these strings as there's a Linux-only issue that was fixed in CEF 1650 (https://bitbucket.org/chromiumembedded/cef/issues/1149/cefsettingsproduct_version-has-no-impact)