Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Commit

Permalink
Um, let's try this again. Don't show parens in About dialog if we don…
Browse files Browse the repository at this point in the history
…'t have a SHA.
  • Loading branch information
njx committed Dec 12, 2012
1 parent 8e32100 commit 1131695
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/help/HelpCommandHandlers.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ define(function (require, exports, module) {
var templateVars = $.extend({ var templateVars = $.extend({
ABOUT_ICON : brackets.config.about_icon, ABOUT_ICON : brackets.config.about_icon,
APP_NAME_ABOUT_BOX : brackets.config.app_name_about, APP_NAME_ABOUT_BOX : brackets.config.app_name_about,
BUILD_INFO : buildInfo BUILD_INFO : buildInfo || ""
}, Strings); }, Strings);
Dialogs.showModalDialogUsingTemplate(Mustache.render(AboutDialogTemplate, templateVars)); Dialogs.showModalDialogUsingTemplate(Mustache.render(AboutDialogTemplate, templateVars));
} }
Expand All @@ -77,7 +77,9 @@ define(function (require, exports, module) {
BuildInfoUtils.getBracketsSHA().done(function (branch, sha, isRepo) { BuildInfoUtils.getBracketsSHA().done(function (branch, sha, isRepo) {
// If we've successfully determined a "build number" via .git metadata, add it to dialog // If we've successfully determined a "build number" via .git metadata, add it to dialog
sha = sha ? sha.substr(0, 9) : ""; sha = sha ? sha.substr(0, 9) : "";
buildInfo = StringUtils.format("({0} {1})", branch, sha).trim(); if (branch || sha) {
buildInfo = StringUtils.format("({0} {1})", branch, sha).trim();
}
}); });


CommandManager.register(Strings.CMD_SHOW_EXTENSIONS_FOLDER, Commands.HELP_SHOW_EXT_FOLDER, _handleShowExtensionsFolder); CommandManager.register(Strings.CMD_SHOW_EXTENSIONS_FOLDER, Commands.HELP_SHOW_EXT_FOLDER, _handleShowExtensionsFolder);
Expand Down

0 comments on commit 1131695

Please sign in to comment.