Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

File should be in working set after File > New #1028

Closed
peterflynn opened this issue Jun 11, 2012 · 5 comments
Closed

File should be in working set after File > New #1028

peterflynn opened this issue Jun 11, 2012 · 5 comments

Comments

@peterflynn
Copy link
Member

  1. File > New
  2. Type filename and hit enter

Result: Newly created file is not in the working set. If you switch to another file, you'll have to dig into the folder tree to re-select the one you just created.

Expected: File is in the working set. It's very likely to be a file of interest... plus, you're almost certainly about to edit it, which would add it to the working set in a moment anyway.

Pretty sure this is not a regression -- it has always behaved this way.

@ghost ghost assigned tvoliter Jun 12, 2012
@pthiess
Copy link
Contributor

pthiess commented Jun 12, 2012

Reviewed Ty is taking this one

@sebasrp
Copy link

sebasrp commented Jul 11, 2012

Hi,
Is there anyone working on this item? I would like to start contributing to this project and this seems an interesting issue that I would like to resolve!

@sebasrp
Copy link

sebasrp commented Jul 13, 2012

Sorry for the previous spam - I should have referenced the issue only in the pull request.
Is there a way to delete those messages? the branches don't exist anymore. Thanks!

redmunds added a commit that referenced this issue Jul 14, 2012
@ghost ghost assigned peterflynn Jul 14, 2012
@redmunds
Copy link
Contributor

FIxed But Not Closed (FBNC). Assigning back to PeterF.

tvoliter added a commit that referenced this issue Jul 16, 2012
…p it selected in the project tree since that is where the user created and named the file.
redmunds added a commit that referenced this issue Jul 17, 2012
tvoliter added a commit that referenced this issue Jul 18, 2012
* origin/master: (23 commits)
  - code review fixes - removed _removePopup() function since complexity of having this helper function isn't worth the savings of reusing the "index" var. I don't except their to be many visible popups at one time, so computing the index more than once isn't costly
  fixes issues #1270 #1271 #1272
  Fix scope of beforeEach/afterEach
  Don't limit ourself in handling key events for html selection only. As we transit to js or css, we still need to dismiss the html code hints popup.
  Code review fixes. Revert menu focus change.
  use public document instead of private _codeMirror
  Fix issue #1240 (Inline editor background doesn't extend all the way to right when scrolling) - CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's _content_ is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number.
  Move the long comment before the corresponding code.
  Code review fixes
  fix return key code
  code review fixes
  initial checkin
  Extract code hint query from tagInfo.tagName instead of extracting it directly from code mirror text using cursor position. Also fix an offset issue in HTMLUtils when the cursor is after white spaces and before a left angle bracket.
  Alternative fix for issue #1028. Add new file in working set, but keep it selected in the project tree since that is where the user created and named the file.
  remove debug code
  fix async loading of extensions. init jasmine after extension tests are loaded
  fix module loading for SpecRunnerUtils
  Additional comments in Menus.js for sections
  Adding function comment blocks to Menus.js
  remove empty menu section test
  ...

Conflicts:
	src/widgets/PopUpManager.js
@peterflynn
Copy link
Member Author

Confirmed fixed

tvoliter added a commit that referenced this issue Jul 31, 2012
* 'master' of github.com:adobe/brackets: (94 commits)
  Don't limit ourself in handling key events for html selection only. As we transit to js or css, we still need to dismiss the html code hints popup.
  Code review fixes. Revert menu focus change.
  use public document instead of private _codeMirror
  Fix issue #1240 (Inline editor background doesn't extend all the way to right when scrolling) - CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's _content_ is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number.
  Move the long comment before the corresponding code.
  Code review fixes
  fix return key code
  Bug fixes
  code review fixes
  Implement generic pop-up Esc key handling
  initial checkin
  Extract code hint query from tagInfo.tagName instead of extracting it directly from code mirror text using cursor position. Also fix an offset issue in HTMLUtils when the cursor is after white spaces and before a left angle bracket.
  Alternative fix for issue #1028. Add new file in working set, but keep it selected in the project tree since that is where the user created and named the file.
  Implement remove all widgets
  remove debug code
  fix async loading of extensions. init jasmine after extension tests are loaded
  Add escape key handling for menus and inline widgets
  Update CodeMirror SHA
  Clarify clickDialogButton async scenarios
  fix module loading for SpecRunnerUtils
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants