This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Esc key closes all inline editors instead of dismissing the context menu. #1272
Assignees
Labels
Comments
ghost
assigned 
|
I can take this since Jason is out |
tvoliter
added a commit
that referenced
this issue
Jul 18, 2012
- fixed ESC key not working to dismiss dialogs by fixing bug where popup was removed from list when it was persistant - simplified addPopUp() API by removing different function call relating to popup persistance and instead having an "autoAddRemove" parameter - prefixed data keys with "PopUpManager" since PopUpManager is decorating elements it doesn't own - changed closing call for menus and context menus to call this.close() instead of closeAll()
|
FBNC @RaymondLim |
|
confirmed fixed. |
tvoliter
added a commit
that referenced
this issue
Jul 18, 2012
* origin/master: (23 commits) - code review fixes - removed _removePopup() function since complexity of having this helper function isn't worth the savings of reusing the "index" var. I don't except their to be many visible popups at one time, so computing the index more than once isn't costly fixes issues #1270 #1271 #1272 Fix scope of beforeEach/afterEach Don't limit ourself in handling key events for html selection only. As we transit to js or css, we still need to dismiss the html code hints popup. Code review fixes. Revert menu focus change. use public document instead of private _codeMirror Fix issue #1240 (Inline editor background doesn't extend all the way to right when scrolling) - CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's _content_ is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number. Move the long comment before the corresponding code. Code review fixes fix return key code code review fixes initial checkin Extract code hint query from tagInfo.tagName instead of extracting it directly from code mirror text using cursor position. Also fix an offset issue in HTMLUtils when the cursor is after white spaces and before a left angle bracket. Alternative fix for issue #1028. Add new file in working set, but keep it selected in the project tree since that is where the user created and named the file. remove debug code fix async loading of extensions. init jasmine after extension tests are loaded fix module loading for SpecRunnerUtils Additional comments in Menus.js for sections Adding function comment blocks to Menus.js remove empty menu section test ... Conflicts: src/widgets/PopUpManager.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Result: All inline editors are closed instead of dismissing the context menu first. If you skip step 2, then the context menu is dismissed on Esc key.
The text was updated successfully, but these errors were encountered: