Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

JS Code Hints parameter tips hidden beneath non-native menu bar #10281

Closed
tnraro opened this issue Dec 26, 2014 · 8 comments
Closed

JS Code Hints parameter tips hidden beneath non-native menu bar #10281

tnraro opened this issue Dec 26, 2014 · 8 comments
Labels
F JS Code Hints in-browser Linux only Starter bug

Comments

@tnraro
Copy link

tnraro commented Dec 26, 2014

2014-12-27 07 58 52

Please fix this.
@RaymondLim
Copy link
Contributor

@tnraro What you're seeing is parameter hinting, not a bug. removeAttributeNode() take one argument of Attribute type. You can see the same parameter hinting in Tern demo page.

@redmunds
Copy link
Contributor

@RaymondLim I think the complaint is that the top of the hint list is truncated, so list should be displayed below the code in this case.

@tnraro
Copy link
Author

tnraro commented Dec 27, 2014

@RaymondLim Oh, It means like @redmunds

@RaymondLim
Copy link
Contributor

@tnraro Sorry that I misunderstood. Yes, you said it in the title.

@peterflynn
Copy link
Member

This only occurs with the HTML menu bar. Looks like a bug in ParamterHintManager -- it's using charCoords() which returns page-global coords, and then positionHint() is only checking for top < 0. It needs to check against the page-global top of the CodeMirror instance instead.

@peterflynn peterflynn changed the title Hidden code hints JS Code Hints parameter tips hidden beneath non-native menu bar Jan 27, 2015
noragrossman added a commit to noragrossman/brackets that referenced this issue Feb 12, 2015
@noragrossman
Added fix for JS Hints, fixes Issue adobe#10281
3c00974
@noragrossman noragrossman mentioned this issue Feb 12, 2015
Closed
@zaggino
Copy link
Contributor

zaggino commented Aug 27, 2016

Now fixed in master:
image

@zaggino zaggino closed this as completed Aug 27, 2016
@zaggino zaggino reopened this Aug 27, 2016
@zaggino
Copy link
Contributor

zaggino commented Aug 27, 2016

My bad, didn't notice linux only, will check it there...

@zaggino
Copy link
Contributor

zaggino commented Aug 28, 2016

Confirmed fixed in latest Linux too.

@zaggino zaggino closed this as completed Aug 28, 2016
This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F JS Code Hints in-browser Linux only Starter bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added fix for JS Hints, fixes Issue #10281 noragrossman/brackets
5 participants
@zaggino @redmunds @peterflynn @RaymondLim @tnraro