This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Added fix for JS Hints, fixes Issue #10281 #10588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (top < 0) { | ||
| // Get the top of the editable document | ||
| var cm = session.editor._codeMirror; | ||
| var localTop = cm.charCoords({line: 0, ch: 0}).top; |
There was a problem hiding this comment.
This won't be correct if the document has been scrolled.
What you want is to compare top to the top bounds of the editor, which is probably something like $editorHolder.offset().top. That ignores split views and looks at the bounds of the entire "main view" content area, but the z-ordering probably works out such that it's ok to overlap a neighboring split-view pane... worth double checking with testing though.
|
Not replicating in master anymore, closing without merge.
|
|
Did you mean to reopen this PR? |
|
It was meant to fix problem on Linux as related issue states, need to boot up linux and check there. I tested windows... |
|
Confirmed fixed in latest Linux too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix Issue #1028