Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Quick Open JS: can't access second function with same name #1109

Closed
peterflynn opened this issue Jun 22, 2012 · 4 comments
Closed

Quick Open JS: can't access second function with same name #1109

peterflynn opened this issue Jun 22, 2012 · 4 comments
Assignees
@peterflynn
Labels
low priority

Comments

@peterflynn
Copy link
Member

  1. Open codemirror.js
  2. Ctrl+T
  3. Type "clipTo"
  4. Arrow down to each result in turn

Result: Both results take you to the same spot, line 2630.

Expected: Since there are two results, they should go to two different declarations. (There really are two different declarations: the second one is on line 2657).

This bug does not affect Quick Edit (inline editor) -- that correctly shows the two results with their different line numbers and different method bodies.
@ghost ghost assigned tvoliter Jun 22, 2012
@peterflynn
Copy link
Member Author

@tvoliter: I have a branch with some Quick Open cleanup that might help with this. I'll check after the sprint closes down & reassign to myself if so.

@pthiess
Copy link
Contributor

pthiess commented Jun 22, 2012

Reviewed - not a blocking issue.

@ghost ghost assigned peterflynn Sep 5, 2012
@peterflynn
Copy link
Member Author

Turns out it's not fixed by my code cleanup -- those changes are necessary but not sufficient. To fully fix this, the JS Quick Open code will need to change from storing ambiguous strings as the search results, to storing something unambiguous like text offsets.

Note: the same bug also occurs for CSS Quick Open (duplicate selectors).

peterflynn added a commit that referenced this issue Sep 25, 2012
@peterflynn
Fix bug #1109 (Quick Open JS: can't access second function with same …
82b7f2d 
…name)

and equivalent bug for CSS & HTML Quick Open. Simplifies logic as well.

Plus two tiny docs fixes.
@peterflynn peterflynn mentioned this issue Sep 25, 2012
Merged
redmunds added a commit that referenced this issue Oct 1, 2012
@redmunds
Merge pull request #1710 from adobe/pflynn/quick-open-dupes
119e1c1 
Fix bug #1109 (Quick Open JS: can't access second function with same name)
@peterflynn peterflynn mentioned this issue Oct 17, 2012
Closed
@peterflynn
Copy link
Member Author

Oops -- closing. The fix for this landed a couple weeks ago.

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterflynn peterflynn

Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tvoliter @peterflynn @pthiess