Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Resizer module uses depreated function #11488

Closed
le717 opened this issue Jul 27, 2015 · 7 comments
Closed

Resizer module uses depreated function #11488

le717 opened this issue Jul 27, 2015 · 7 comments

Comments

@le717
Copy link
Contributor

le717 commented Jul 27, 2015

(Split from #11174 (comment))

src/utils/Resizer.js uses PreferencesManager.convertPreferences. which is deprecated, so the error is being thrown in core. I have no clue how that preference should be updated to the current system (prefixed? Global preferences file), and I am unsure if deprecation errors should be thrown in core (I think historically that is a "no").

@marcelgerber marcelgerber changed the title Rezier module uses depreated function Resizer module uses depreated function Jul 29, 2015
@ficristo
Copy link
Collaborator

/cc @peterflynn @abose
Do you know how to fix this?

@abose
Copy link
Contributor

abose commented Feb 1, 2016

also see related use in src/project/ProjectManager.js.

@sprintr
Copy link
Contributor

sprintr commented Feb 1, 2016

I removed all the code using deprecated API and Brackets kept on working. I seem to have lost that branch.

@abose
Copy link
Contributor

abose commented Feb 1, 2016

Was there a lot of places using deprecated API in core?

@sprintr
Copy link
Contributor

sprintr commented Feb 1, 2016

15-20 places maybe. I'll submit a PR tonight.

@abose
Copy link
Contributor

abose commented Feb 1, 2016

👍 Thanks @sprintr

@sprintr
Copy link
Contributor

sprintr commented May 13, 2019

@swmitra This is fixed and should be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants
@le717 @sprintr @abose @ficristo @shubhsnov and others