New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for convertPreferences() #11174

Merged
merged 1 commit into from Jun 20, 2015

Conversation

Projects
None yet
6 participants
@le717
Contributor

le717 commented May 27, 2015

For #10412.

@nethip Any suggestions for the message wording?

@@ -528,7 +532,7 @@ define(function (require, exports, module) {
* @return {boolean} true if a value was set
*/
function setValueAndSave(id, value, options) {
DeprecationWarning.deprecationWarning("setValueAndSave called for " + id + ". Use set instead.");

This comment has been minimized.

@nethip

nethip Jun 8, 2015

Contributor

@le717 Wording looks OK to me. Should we make use of the second param, oncePerCaller, for deprecationWarning.

@nethip

nethip Jun 8, 2015

Contributor

@le717 Wording looks OK to me. Should we make use of the second param, oncePerCaller, for deprecationWarning.

This comment has been minimized.

@le717

le717 Jun 12, 2015

Contributor

Sure thing.

@le717

le717 Jun 12, 2015

Contributor

Sure thing.

@le717

This comment has been minimized.

Show comment
Hide comment
@le717

le717 Jun 12, 2015

Contributor

@nethip Suggested change made, ready to go.

Contributor

le717 commented Jun 12, 2015

@nethip Suggested change made, ready to go.

@MarcelGerber

View changes

Show outdated Hide outdated src/preferences/PreferencesManager.js Outdated
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 13, 2015

Contributor

Could you also add the @deprecated JSDoc to getPreferenceStorage?

Contributor

MarcelGerber commented Jun 13, 2015

Could you also add the @deprecated JSDoc to getPreferenceStorage?

@le717

This comment has been minimized.

Show comment
Hide comment
@le717

le717 Jun 14, 2015

Contributor

@MarcelGerber All changes made.

Contributor

le717 commented Jun 14, 2015

@MarcelGerber All changes made.

@rroshan1

View changes

Show outdated Hide outdated src/preferences/PreferencesManager.js Outdated

@MarcelGerber MarcelGerber added this to the Release 1.4 milestone Jun 15, 2015

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 20, 2015

Contributor

The messages are still not quite streamlined, but as it's unlikely, for an end user, to get both at the same time, I'll merge anyway.

Contributor

MarcelGerber commented Jun 20, 2015

The messages are still not quite streamlined, but as it's unlikely, for an end user, to get both at the same time, I'll merge anyway.

MarcelGerber added a commit that referenced this pull request Jun 20, 2015

Merge pull request #11174 from le717/issue-10412
Add deprecation warning for convertPreferences()

@MarcelGerber MarcelGerber merged commit 1a74ece into adobe:master Jun 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jul 7, 2015

Contributor

PreferencesManager.convertPreferences is still being used in the core in src/utils/Resizer.js. I think it should be safe to remove it. _isPanelPreferences should be removed as well.

Edit: There are more than one instance where it is being used.

Contributor

sprintr commented Jul 7, 2015

PreferencesManager.convertPreferences is still being used in the core in src/utils/Resizer.js. I think it should be safe to remove it. _isPanelPreferences should be removed as well.

Edit: There are more than one instance where it is being used.

@le717 le717 deleted the le717:issue-10412 branch Jul 16, 2015

@le717

This comment has been minimized.

Show comment
Hide comment
@le717

le717 Jul 16, 2015

Contributor

@sprintr Apologies for what's probably a dumb question, but how exactly would that be updated? Resizer is a core (but not core extension) module, but I have never seen a panelState key in the preferences file.

Contributor

le717 commented Jul 16, 2015

@sprintr Apologies for what's probably a dumb question, but how exactly would that be updated? Resizer is a core (but not core extension) module, but I have never seen a panelState key in the preferences file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment