Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

StatusBar UI-updating code probably doesn't belong in EditorManager #1869

Closed
peterflynn opened this issue Oct 17, 2012 · 6 comments
Closed

Comments

@peterflynn
Copy link
Member

In Sprint 15 we added about 130 lines of code to EditorManager that maintains the various status labels in the status bar (cursor pos, current syntax mode, tab settings, etc.). EditorManager is a low-level core module and probably shouldn't be acting as the view/controller layer for the status bar.

StatusBar.js is probably also not the right place, since it seems to be intended more as a generic container that various modules can plug into. We may want to create a new module, e.g. EditorStatus or EditorStatusBar, to contain this code.

@peterflynn
Copy link
Member Author

p.s. We've already seen some intertangling of core Editor-management code with status bar UI-updating code as a result of this -- witness the refresh() calls that snuck into _onFocusedEditorChange(), which are probably contributing to the scrolling issue noted in #1864.

@redmunds
Copy link
Contributor

We may also want to move StatusBar.html to the htmlContent folder.

@ghost ghost assigned redmunds Oct 18, 2012
@pthiess
Copy link
Contributor

pthiess commented Oct 18, 2012

Reviewed and assigned to @redmunds

@njx
Copy link
Contributor

njx commented Nov 10, 2012

This didn't have a priority--adding "low priority" (though I could be convinced it's medium priority, since we'd like to avoid messy dependencies).

@ghost ghost assigned peterflynn Mar 8, 2013
@peterflynn
Copy link
Member Author

I have a fix up for this in pull #3061

@jbalsas
Copy link
Contributor

jbalsas commented Mar 9, 2013

Fix merged. Closing and adding milestone Sprint22.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants