Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Investigate circular dependencies #1998

Open
gruehle opened this issue Oct 31, 2012 · 2 comments
Open

Investigate circular dependencies #1998

gruehle opened this issue Oct 31, 2012 · 2 comments

Comments

@gruehle
Copy link
Member

gruehle commented Oct 31, 2012

Running madge on the Brackets source shows that we have a number of circular dependencies.

Some of these are known, like DocumentManager<-->EditorManager, and would be very difficult to break. Others should be easy fixes. We should investigate each of these and split the easy fixes into separate bugs.

> madge --circular src/
document/DocumentManager -> editor/EditorManager
editor/EditorManager -> editor/Editor -> command/Menus
editor/EditorManager -> editor/Editor -> command/Menus -> widgets/PopUpManager
editor/EditorManager -> editor/Editor -> editor/CodeHintManager
editor/EditorManager -> editor/Editor
preferences/PreferencesManager -> preferences/PreferenceStorage
document/DocumentManager -> editor/EditorManager -> editor/InlineTextEditor
editor/EditorManager -> editor/InlineTextEditor
editor/EditorManager -> editor/InlineTextEditor -> editor/InlineWidget
editor/EditorManager -> widgets/StatusBar
document/DocumentManager -> project/ProjectManager
project/ProjectManager -> preferences/PreferencesDialogs
document/DocumentManager -> project/ProjectManager -> project/FileViewController
@peterflynn
Copy link
Member

EditorManager -> Statusbar is covered by #1869

Editor -> Menus is only there to close popups on scroll, which might be changed by #1381.

@pthiess
Copy link
Contributor

pthiess commented Nov 6, 2012

Reviewed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants