Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Save As in folder tree context menu seems weird #4548

Closed
peterflynn opened this issue Jul 23, 2013 · 1 comment
Closed

Save As in folder tree context menu seems weird #4548

peterflynn opened this issue Jul 23, 2013 · 1 comment
Assignees
@peterflynn
Labels
fix in progress

Comments

@peterflynn
Copy link
Member

  1. Right click any file in the project tree
  2. Right click any folder in the project tree

Result:
All project tree items show "Save As" in the context menu. This seems weird because 99% of them are not actually open for editing. I guess you could be using Save As there as a hacky substitute for file-copy, but it feels a little weird.

Even more weird is that all folders also have a Save As item. Clicking it invokes Save As on whatever is currently open in the editor (which has nothing to do with where you right clicked). It throws an exception when clicked if nothing is open in the editor area.

Since it seems weird for files too, I vote we just remove it entirely -- so it'll only be in the working set context menu.
peterflynn added a commit that referenced this issue Jul 23, 2013
@peterflynn
* Fix bug #4548 - remove Save As from folder tree context menu
5e803b4 
* Fix exception thrown when File > Save As invoked with nothing open
* Update docs for working set events to reflect PR #4450
@ghost ghost assigned peterflynn Jul 23, 2013
@peterflynn peterflynn mentioned this issue Jul 23, 2013
Merged
@RaymondLim
Copy link
Contributor

Verified that we no longer show "Save As..." in project context menu, but "Save As..." from working set context menu still works.

peterflynn added a commit that referenced this issue Jul 30, 2013
@peterflynn
Merge remote-tracking branch 'origin/master' into pflynn/unit-test-cl…
8d94d0d 
…eanups

* origin/master: (30 commits)
  turn off optimization in acorn (but not acorn_loose right now)
  cleanup unit test prefs
  temporarily switch to my tern
  Revert "Revert "Workaround for the Tern crash.""
  Update README.md
  Work around #4554 (Extension Manager font is hard to read on Windows), which is a Chromium bug, by avoiding the lightest font-weight on Win. Lighten the text slightly so it's still a little muted, like the design looks on Mac and with older CEFs on Win.
  Revert "Workaround for the Tern crash."
  Updated by ALF automation.
  Re-add toolbar hover. Fix some button appearance issues.
  Updated by ALF automation.
  * Fix bug #4548 - remove Save As from folder tree context menu * Fix exception thrown when File > Save As invoked with nothing open * Update docs for working set events to reflect PR #4450
  integration tests for registerInlineEditProvider
  Fixes after review
  JSDoc fixes.
  Fix for extensions compare
  show error message and add safety check
  For #4535, show error message but not 'remove' link for bad extension in dev folder
  Refactor provider callback for export
  Generalize registerInlineEditProvider and registerInlineDocProvider to take an optional priority parameter
  change upper limit to 16000
  ...
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterflynn peterflynn

Labels
fix in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterflynn @RaymondLim