Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Dark Shell][Core]: There is an extra white line between the title bar and menu bar when resize the window. #5288

Closed
julieyuan opened this issue Sep 22, 2013 · 19 comments

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. Double click the title bar to maximize the window.
  3. Double click the title bar again to restore to orginial window size.
  4. Move the cursor between title bar and menu bar.
  5. Hover the mouse on the menus.

Results:
At step4, there will appear one white line between the title bar and menu bar.
At step5, when hover mouse on different menus, the white line will be overlapped by the menus. When click anywhere on the Brackets, the white line will disappear.

Expected:
Actually , I prefer to have this white line between the title bar and menu bar for it makes the UI much clear. But I think it will be good that this line is fixed(not flexible), or else it is not exist. The menus overlapping the white line is not good for user experience.

ENV: Win8.1 English OS
Build: 0.32.0-9586

Snapshots:
Please refer to snapshots for details:
111

@gruehle
Copy link
Member

gruehle commented Sep 23, 2013

Medium priority to @JeffryBooher

FYI: I can't repro in my Windows 8 VM...

@peterflynn
Copy link
Member

@gruehle I think you meant to say can't repro, right? It's UTR for me on my Win 7 machine too...

@julieyuan
Copy link
Author

Checked it again. This issue not reproduces on my Win8.1 VM today. I will look into this issue and give feedback then.

@dalcala
Copy link

dalcala commented Sep 24, 2013

These steps are UTR for me, but I've encountered this symptom multiple times using BK 31 on Win 7 x64 English and I wasn't clicking the BK icon. It's pretty random though. I'm pretty sure I was just minimizing Brackets and then opening it again. The line I'm seeing looks a little different than Julie's.

bk-darkness-artifact fw

@dalcala
Copy link

dalcala commented Sep 24, 2013

I can get this to repro every time now on Win7 with the following steps. I made a video here: http://screencast.com/t/NcpSOX3c.

  1. Pin BK icon to Win 7 task bar
  2. Delete BK user config folder (C:\Users[user]\AppData\Roaming) (not sure if this is necessary or not)
  3. Open BK by clicking the BK pinned Task Bar icon, but leave the mouse hovering over the pinned task bar icon. Don't move the mouse!!
  4. Wait until index.html renders (not sure if waiting for render is necessary or not)
  5. Minimize BK by clicking the BK pinned Task Bar icon (again don't move the mouse - it should still be hovering over task bar icon).
  6. Show BK by clicking the BK pinned Task Bar icon but leave the mouse hovering over the BK pinned task bar icon.
  7. Slowly move the mouse up into the bottom area of BK.
    -> White line appears under title bar

@ram19890
Copy link

Open Brackets (ver:31 or ver:32)
Windows+D
Maximize Brackets
Right click the icon at the top left
YOU WILL SEE IT !!!
It shows the same classic windows , even if any file is open or not!

@peterflynn
Copy link
Member

See #5321 for additional ways to reproduce this.

@ghost ghost assigned JeffryBooher Oct 31, 2013
@peterflynn
Copy link
Member

Nominating for Sprint 34

@ZhaoMuwei
Copy link

May I provide some additional info:
the almost exact problem occured to me when using Sprint 31 & 34.1, except that it happened when I Right Click on the title bar, not hovering or clicking on the app icon.

brackets-title-bug

@njx
Copy link
Contributor

njx commented Dec 16, 2013

See also #6221, which has an issue that looks like @LokerZhao's above. Should verify that the fix for this also fixes that.

@le717
Copy link
Contributor

le717 commented Jan 8, 2014

I am also getting this bug, Windows 8.1 Core x64 and Brackets Sprint 35. I'm using normal sized fonts, so that can't be it. It only happens every so often, but I can confirm #5288 (comment) does reproduce the bug (save steps 2 and 4, which are unneeded). I also found that clicking on the line makes it go away. 😕

@peterflynn
Copy link
Member

@JeffryBooher This still repros for me on XP with the new shell build (ad hoc -- need to nail down repro steps). But not Win7.

@peterflynn
Copy link
Member

Steps:

  1. Click in taskbar to minimize window
  2. Click in taskbar again to restore window
  3. Open any menu by clicking

This works regardless of the initial window size before step 1 (maximized or not maximized)

@peterflynn
Copy link
Member

Also repros if you replace step 1 with Windows+D shortcut, as reported above.

I don't think this should block landing the new aero shell in Sprint 36 though -- it's still clearly an improvement over the current build (and fixes the bug entirely for the majority of users).

@peterflynn
Copy link
Member

@JeffryBooher I've seen this a couple times on Windows 7 still with the new shell (or something very much like it -- I think the line was appearing below the menu bar instead of above; I'll try to get a screenshot next time). Repro steps seem much harder, so I don't know how to get it to occur consistently. Just fyi.

@Leninsky
Copy link

Leninsky commented Feb 2, 2014

Hello everyone, even if this is not a major bug it can get annoying when you want to show off your new text editor to your friends. :)
Therefore until there is a new version fixing the issue I am very happy with going to Properties -> Compatibility and ticking the Disable visual themes option. This disables the dark shell and the problem is gone. (actually I am very happy with this solution because I like the aero shell more in Windows 7)

@peterflynn
Copy link
Member

@isti37 The issue will be almost entirely gone in the Sprint 36 build, which is due to be released within the week.

@bchintx
Copy link
Contributor

bchintx commented May 20, 2014

With brackets-shell pull request #445 I'm no longer seeing any white lines above or below the main menu. I was previously seeing it when resizing the window frame horizontally.

Back to @julieyuan to consider closing as fixed.

@Zhuyun
Copy link

Zhuyun commented May 23, 2014

Didn't see it in build 0.40.0-12993. Close as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests