Live Dev is Broken #5365
Comments
|
Crud, looks like we missed a subtle diff between the two APIs that were merged -- one includes the leading "." and the other doesn't. Excluding the "." seems more correct but that means changing a public API. Do we have any sense of how many callers it has? |
|
I only see one call each in JSUtils and FileIndexManager, but the other question is how many extensions might be using it... |
|
The other option is to keep the weird "."-prefixed public API bug with a deprecation warning, and put up a new one with the cleaner semantic before ripping out the old one next sprint. I'm not exactly in love with the current API name anyway :-) |
|
I did a grep in all the existing extensions using @dangoor's handy-dandy Brackets Extension Grabber and found four instances in three extensions out of about a hundred. (A couple of extensions didn't download for some reason.) I highly recommend BracketsExtensionGrabber, btw. (Note that it's missing one of the deps in the package.json currently--I put up a pull request to fix that.) |
|
BTW, the extensions were angularui.angularjs, brackets-code-folding, and pflynn.svg.preview. |
ghost
assigned introduce new FileUtils.getFileExtension() (which excludes it). Fixes bug #5365.
|
FBNC @redmunds |
|
Confirmed. Closing. |
|
I updated the release notes & filed #5368 for permanently removing the old deprecated API. Will file bugs on the extensions shortly. |
Merge branch 'glenn/file-system' into pflynn/in-browser-file-system * glenn/file-system: (56 commits) Change FileSystemManager.createFileSystem() to be async -- allowing filesystem impls time to seed any required initial data, or go through authentication workflows. Fix incorrect JSDoc parameter name. Updated by ALF automation. Update Tern and Acorn to the latest Change decompress-zip to the release Remove methods from eports Fix minor nit Added quick-edit.png for Finnish translation Find in Files title update restore handleWideResults property Deprecate FileUtils.getFilenameExtension() (which includes leading "."), introduce new FileUtils.getFileExtension() (which excludes it). Fixes bug #5365. Clean up Fix #5362 (HTML menu z-index vs. bottom-panel). simplify fix by assuming intent is to type (not insert hint) Code review cleanups Expose code inspection providers for the extensions. Update to decompress-zip that includes fix for our issue. Code review: use more consts in Find; remove unneeded single-tickmark API hasNativeMenus param code cleanup code cleanup ... Conflicts: src/project/ProjectManager.js
Results
Error "Open an HTML file in order to launch live preview"
git bisectpoints to this commit: 68a5189In this pull request: #5224
cc: @peterflynn @JeffryBooher
The text was updated successfully, but these errors were encountered: