This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Find in Files treats \n, \r, etc. as regular expressions #971
Assignees
Labels
Comments
ghost
assigned 
|
Experimental feature, setting priority to low. |
mikechambers
pushed a commit
to mikechambers/brackets
that referenced
this issue
Jun 17, 2012
* origin/master: (33 commits) code review comments Update comments Update CodeMirror SHA code review fixes Restore Shift-Tab to outdent behavior Re-implement performance suite filtering due to RequireJS changes in SpecRunner Revert .json file listing of test suites. Add ExtensionUtils to root require context added a comment explaining why we aren't using jquery deferreds for the done loading notification Fix adobe#971 (Find in Files treats \n, \r, etc. as regular expressions) -- Escape backslash too (and simplify escaping regexp to use char class instead of |). createTestWindowAndRun now waits for brackets to be completely done loading (so extensions are loaded before tests run) added a 'ready' event to brackets that fires when brackets is completely done loading Rewrote unit tests for JavaScriptInlineEditor to get JSUtils from the require context that was used to load the extension. We only need to do this in unit tests where we rely on JSUtils to get the DocumentManager, etc. from the current window. Modified ExtensionLoader to allow for retrieving the require context that loaded an extension Refactor loadStyleSheet. Change error handling. provide way for unit tests to restore commands after a reset Fixed bug where triangle wasn't updating correctly by toggling "scroll" events on double click show Fix for double-click not working Removed unused comments Code review fixes. ...
mikechambers
pushed a commit
to mikechambers/brackets
that referenced
this issue
Jun 17, 2012
* origin/master: (45 commits) code review comments Update comments Update CodeMirror SHA code review fixes Restore Shift-Tab to outdent behavior Re-implement performance suite filtering due to RequireJS changes in SpecRunner Revert .json file listing of test suites. Add ExtensionUtils to root require context added a comment explaining why we aren't using jquery deferreds for the done loading notification Fix adobe#971 (Find in Files treats \n, \r, etc. as regular expressions) -- Escape backslash too (and simplify escaping regexp to use char class instead of |). createTestWindowAndRun now waits for brackets to be completely done loading (so extensions are loaded before tests run) added a 'ready' event to brackets that fires when brackets is completely done loading Code review fixes. Combined both offset to lines functions into a single function Rewrote unit tests for JavaScriptInlineEditor to get JSUtils from the require context that was used to load the extension. We only need to do this in unit tests where we rely on JSUtils to get the DocumentManager, etc. from the current window. Modified ExtensionLoader to allow for retrieving the require context that loaded an extension Refactor loadStyleSheet. Change error handling. make red bolder provide way for unit tests to restore commands after a reset Changed click handler to use $.on so runtime added menus work Fixed bug where triangle wasn't updating correctly by toggling "scroll" events on double click show ... Conflicts: test/BootstrapReporter.js test/UnitTestSuite.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Result: Brackets hangs for a while, then produces 100,000+ search results (one for every line of code).
Expected: only files that contain the string "\n". (The search query is only supposed to get interpreted as a regexp if it's wrapped like /\n/).
Looks like a straightforward missed case in the escaping done by FindInFiles._getQueryRegExp().
The text was updated successfully, but these errors were encountered: