New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Farsi (fa-ir) strings.js #10254

Merged
merged 8 commits into from Apr 16, 2015

Conversation

Projects
None yet
6 participants
@Rezaaa
Contributor

Rezaaa commented Dec 20, 2014

No description provided.

@Rezaaa Rezaaa closed this Dec 21, 2014

@Rezaaa Rezaaa reopened this Dec 21, 2014

@busykai

This comment has been minimized.

Show comment
Hide comment
@busykai

busykai Dec 22, 2014

Contributor

@Rezaaa, you need to sign Contributor License Agreement before your contribution could be accepted.

Contributor

busykai commented Dec 22, 2014

@Rezaaa, you need to sign Contributor License Agreement before your contribution could be accepted.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 12, 2015

Contributor

@busykai signed.

Contributor

Rezaaa commented Jan 12, 2015

@busykai signed.

@busykai busykai changed the title from Update strings.js to Update Farsi (fa-ir) strings.js Jan 12, 2015

@busykai

This comment has been minimized.

Show comment
Hide comment
@busykai

busykai Jan 12, 2015

Contributor

Clarified the title.

@datamweb, you're the author of the original translation. Do you have time to review this?

Contributor

busykai commented Jan 12, 2015

Clarified the title.

@datamweb, you're the author of the original translation. Do you have time to review this?

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 12, 2015

Contributor

Hi,
@busykai ,yes.But ...
@Rezaaa please check line 591.

Contributor

datamweb commented Jan 12, 2015

Hi,
@busykai ,yes.But ...
@Rezaaa please check line 591.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 12, 2015

Contributor

@datamweb ok. what's the problem?

Contributor

Rezaaa commented Jan 12, 2015

@datamweb ok. what's the problem?

@busykai busykai referenced this pull request Jan 12, 2015

Closed

Update strings.js #10360

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 12, 2015

Contributor

this problem is linguistic. Misspellings of the word loading(بارگذاری).

Contributor

datamweb commented Jan 12, 2015

this problem is linguistic. Misspellings of the word loading(بارگذاری).

@busykai

This comment has been minimized.

Show comment
Hide comment
@busykai

busykai Jan 12, 2015

Contributor

@datamweb, @Rezaaa you could actually click on Files changed tab above and then add comments to the specific change it relates to.

also, @Rezaaa, please merge your other PR (#10360) to this one so that all the changes could be reviewed once and in a single place.

Contributor

busykai commented Jan 12, 2015

@datamweb, @Rezaaa you could actually click on Files changed tab above and then add comments to the specific change it relates to.

also, @Rezaaa, please merge your other PR (#10360) to this one so that all the changes could be reviewed once and in a single place.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 12, 2015

Contributor
Contributor

Rezaaa commented Jan 12, 2015

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 12, 2015

Contributor

this site is the filter for me.so edit all word to (بارگذاری).and check line 244.

Contributor

datamweb commented Jan 12, 2015

this site is the filter for me.so edit all word to (بارگذاری).and check line 244.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 12, 2015

Contributor

@datamweb done.

Contributor

Rezaaa commented Jan 12, 2015

@datamweb done.

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 12, 2015

thanks for fix.but plase Change “ to " line 313.

datamweb commented on src/nls/fa-ir/strings.js in d166fd8 Jan 12, 2015

thanks for fix.but plase Change “ to " line 313.

Update strings.js
fixed 313 & 319
"CMD_OPEN_FOLDER" : "باز کردن پوشه\u2026",
"CMD_FILE_CLOSE" : "بستن",
"CMD_FILE_CLOSE_ALL" : "بستن همه",
"CMD_FILE_CLOSE_LIST" : "بستن لیست",
"CMD_FILE_CLOSE_OTHERS" : "ستن سایر موارد",
"CMD_FILE_CLOSE_OTHERS" : "بستن سایر موارد",

This comment has been minimized.

@Rezaaa

Rezaaa Jan 12, 2015

Contributor

@datamweb fixed.

@Rezaaa

Rezaaa Jan 12, 2015

Contributor

@datamweb fixed.

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb commented on src/nls/fa-ir/strings.js in 0c33452 Jan 13, 2015

ok.

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb commented on src/nls/fa-ir/strings.js in 0c33452 Jan 13, 2015

ok

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 13, 2015

Contributor

@datamweb so please merge it. thank u.

Contributor

Rezaaa commented Jan 13, 2015

@datamweb so please merge it. thank u.

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 13, 2015

Contributor

@Rezaaa You've made a lot of errors. Please be resolved.

Contributor

datamweb commented Jan 13, 2015

@Rezaaa You've made a lot of errors. Please be resolved.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 13, 2015

Contributor

@datamweb i solved your misspellings! where is my errors?!

Contributor

Rezaaa commented Jan 13, 2015

@datamweb i solved your misspellings! where is my errors?!

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Jan 13, 2015

Contributor

@Rezaaa Please check the JSHint log from TravisCI for the list of current linting errors: https://travis-ci.org/adobe/brackets/builds/46781391#L332.

Contributor

Mark-Simulacrum commented Jan 13, 2015

@Rezaaa Please check the JSHint log from TravisCI for the list of current linting errors: https://travis-ci.org/adobe/brackets/builds/46781391#L332.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 13, 2015

Contributor

@Mark-Simulacrum @datamweb the problem is half space character. sorry.

Contributor

Rezaaa commented Jan 13, 2015

@Mark-Simulacrum @datamweb the problem is half space character. sorry.

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 13, 2015

Contributor

@Rezaaa you click on the Details or use @Mark-Simulacrum commented.

Contributor

datamweb commented Jan 13, 2015

@Rezaaa you click on the Details or use @Mark-Simulacrum commented.

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 14, 2015

Contributor

@datamweb is there any problem yet?

Contributor

Rezaaa commented Jan 14, 2015

@datamweb is there any problem yet?

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 15, 2015

Contributor

@Rezaaa thanks for my solved misspellings 👍 .
When I was translating I had used RTL css file of Brackts and there remains the problem. for example: line 175 is false. Because the displays the :شما درحال استفاده از آخرین نسخه {APP_NAME} هستید.
True : .هستید {APP_NAME} شما در حال استفاده از آخرین نسخه
so pleas fix lin 412,420,421and...
do you like the fix?

Contributor

datamweb commented Jan 15, 2015

@Rezaaa thanks for my solved misspellings 👍 .
When I was translating I had used RTL css file of Brackts and there remains the problem. for example: line 175 is false. Because the displays the :شما درحال استفاده از آخرین نسخه {APP_NAME} هستید.
True : .هستید {APP_NAME} شما در حال استفاده از آخرین نسخه
so pleas fix lin 412,420,421and...
do you like the fix?

@Rezaaa

This comment has been minimized.

Show comment
Hide comment
@Rezaaa

Rezaaa Jan 15, 2015

Contributor

@datamweb me@rezamahmoudi.ir Send me an email

Contributor

Rezaaa commented Jan 15, 2015

@datamweb me@rezamahmoudi.ir Send me an email

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Jan 15, 2015

Contributor

@Rezaaa ok. Please cheke your email.

Contributor

datamweb commented Jan 15, 2015

@Rezaaa ok. Please cheke your email.

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Mar 10, 2015

Contributor

@datamweb Are we good with the translation? Can this be merged?

Contributor

nethip commented Mar 10, 2015

@datamweb Are we good with the translation? Can this be merged?

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Mar 10, 2015

Contributor

Hi,
@nethip Please wait.
@Rezaaa Please, between lines 319 and 320 add a new line. As follows:
"CMD_TOGGLE_LIVE_PREVIEW_MB_MODE": "Enable Experimental Live Preview",
And then the last line:
/ * Last translated for c292e89 * /
To the
/ * Last translated for eef9c68 * /
Change.

Contributor

datamweb commented Mar 10, 2015

Hi,
@nethip Please wait.
@Rezaaa Please, between lines 319 and 320 add a new line. As follows:
"CMD_TOGGLE_LIVE_PREVIEW_MB_MODE": "Enable Experimental Live Preview",
And then the last line:
/ * Last translated for c292e89 * /
To the
/ * Last translated for eef9c68 * /
Change.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Apr 15, 2015

Contributor

@datamweb @Rezaaa Can this translations be merged now?

Contributor

abose commented Apr 15, 2015

@datamweb @Rezaaa Can this translations be merged now?

@datamweb

This comment has been minimized.

Show comment
Hide comment
@datamweb

datamweb Apr 16, 2015

Contributor

Hi,
@abose ,@RaymondLim please marged.
@Rezaaa thanks for fixing.

Contributor

datamweb commented Apr 16, 2015

Hi,
@abose ,@RaymondLim please marged.
@Rezaaa thanks for fixing.

abose added a commit that referenced this pull request Apr 16, 2015

Merge pull request #10254 from Rezaaa/patch-1
Update Farsi (fa-ir) strings.js

@abose abose merged commit 797cee7 into adobe:master Apr 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment