Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update Farsi (fa-ir) strings.js #10254

Merged
merged 8 commits into from
Apr 16, 2015
Merged

Update Farsi (fa-ir) strings.js #10254

merged 8 commits into from
Apr 16, 2015

Conversation

rezaaa
Copy link
Contributor

@rezaaa rezaaa commented Dec 20, 2014

No description provided.

@rezaaa rezaaa closed this Dec 21, 2014
@rezaaa rezaaa reopened this Dec 21, 2014
@busykai
Copy link
Contributor

busykai commented Dec 22, 2014

@rezaaa, you need to sign Contributor License Agreement before your contribution could be accepted.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 12, 2015

@busykai signed.

@busykai busykai changed the title Update strings.js Update Farsi (fa-ir) strings.js Jan 12, 2015
@busykai
Copy link
Contributor

busykai commented Jan 12, 2015

Clarified the title.

@datamweb, you're the author of the original translation. Do you have time to review this?

@datamweb
Copy link
Contributor

Hi,
@busykai ,yes.But ...
@rezaaa please check line 591.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 12, 2015

@datamweb ok. what's the problem?

@busykai busykai mentioned this pull request Jan 12, 2015
@datamweb
Copy link
Contributor

this problem is linguistic. Misspellings of the word loading(بارگذاری).

@busykai
Copy link
Contributor

busykai commented Jan 12, 2015

@datamweb, @rezaaa you could actually click on Files changed tab above and then add comments to the specific change it relates to.

also, @rezaaa, please merge your other PR (#10360) to this one so that all the changes could be reviewed once and in a single place.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 12, 2015

@datamweb I think it is correct : http://www.loghatnaameh.org/dehkhodaworddetail-44a955b363b5481592e1eefb0cf811a3-fa.html

why do u think it has misspelling?

@datamweb
Copy link
Contributor

this site is the filter for me.so edit all word to (بارگذاری).and check line 244.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 12, 2015

@datamweb done.

fixed 313 & 319
"CMD_OPEN_FOLDER" : "باز کردن پوشه\u2026",
"CMD_FILE_CLOSE" : "بستن",
"CMD_FILE_CLOSE_ALL" : "بستن همه",
"CMD_FILE_CLOSE_LIST" : "بستن لیست",
"CMD_FILE_CLOSE_OTHERS" : "ستن سایر موارد",
"CMD_FILE_CLOSE_OTHERS" : "بستن سایر موارد",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datamweb fixed.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 13, 2015

@datamweb so please merge it. thank u.

@datamweb
Copy link
Contributor

@rezaaa You've made a lot of errors. Please be resolved.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 13, 2015

@datamweb i solved your misspellings! where is my errors?!

@Mark-Simulacrum
Copy link
Contributor

@rezaaa Please check the JSHint log from TravisCI for the list of current linting errors: https://travis-ci.org/adobe/brackets/builds/46781391#L332.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 13, 2015

@Mark-Simulacrum @datamweb the problem is half space character. sorry.

@datamweb
Copy link
Contributor

@rezaaa you click on the Details or use @Mark-Simulacrum commented.

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 14, 2015

@datamweb is there any problem yet?

@datamweb
Copy link
Contributor

@rezaaa thanks for my solved misspellings 👍 .
When I was translating I had used RTL css file of Brackts and there remains the problem. for example: line 175 is false. Because the displays the :شما درحال استفاده از آخرین نسخه {APP_NAME} هستید.
True : .هستید {APP_NAME} شما در حال استفاده از آخرین نسخه
so pleas fix lin 412,420,421and...
do you like the fix?

@rezaaa
Copy link
Contributor Author

rezaaa commented Jan 15, 2015

@datamweb me@rezamahmoudi.ir Send me an email

@datamweb
Copy link
Contributor

@rezaaa ok. Please cheke your email.

@nethip
Copy link
Contributor

nethip commented Mar 10, 2015

@datamweb Are we good with the translation? Can this be merged?

@datamweb
Copy link
Contributor

Hi,
@nethip Please wait.
@rezaaa Please, between lines 319 and 320 add a new line. As follows:
"CMD_TOGGLE_LIVE_PREVIEW_MB_MODE": "Enable Experimental Live Preview",
And then the last line:
/ * Last translated for c292e89 * /
To the
/ * Last translated for eef9c68 * /
Change.

@abose
Copy link
Contributor

abose commented Apr 15, 2015

@datamweb @rezaaa Can this translations be merged now?

@datamweb
Copy link
Contributor

Hi,
@abose ,@RaymondLim please marged.
@rezaaa thanks for fixing.

abose added a commit that referenced this pull request Apr 16, 2015
Update Farsi (fa-ir) strings.js
@abose abose merged commit 797cee7 into adobe:master Apr 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants