Update Farsi (fa-ir) strings.js #10254

Merged
merged 8 commits into from Apr 16, 2015

Projects

None yet

6 participants

@Rezaaa
Contributor
Rezaaa commented Dec 20, 2014

No description provided.

@Rezaaa Rezaaa closed this Dec 21, 2014
@Rezaaa Rezaaa reopened this Dec 21, 2014
@busykai
Member
busykai commented Dec 22, 2014

@Rezaaa, you need to sign Contributor License Agreement before your contribution could be accepted.

@Rezaaa
Contributor
Rezaaa commented Jan 12, 2015

@busykai signed.

@busykai busykai changed the title from Update strings.js to Update Farsi (fa-ir) strings.js Jan 12, 2015
@busykai
Member
busykai commented Jan 12, 2015

Clarified the title.

@datamweb, you're the author of the original translation. Do you have time to review this?

@datamweb
Contributor

Hi,
@busykai ,yes.But ...
@Rezaaa please check line 591.

@Rezaaa
Contributor
Rezaaa commented Jan 12, 2015

@datamweb ok. what's the problem?

@busykai busykai referenced this pull request Jan 12, 2015
Closed

Update strings.js #10360

@datamweb
Contributor

this problem is linguistic. Misspellings of the word loading(بارگذاری).

@busykai
Member
busykai commented Jan 12, 2015

@datamweb, @Rezaaa you could actually click on Files changed tab above and then add comments to the specific change it relates to.

also, @Rezaaa, please merge your other PR (#10360) to this one so that all the changes could be reviewed once and in a single place.

@Rezaaa
Contributor
Rezaaa commented Jan 12, 2015
@datamweb
Contributor

this site is the filter for me.so edit all word to (بارگذاری).and check line 244.

@Rezaaa
Contributor
Rezaaa commented Jan 12, 2015

@datamweb done.

@datamweb

thanks for fix.but plase Change “ to " line 313.

@Rezaaa Rezaaa commented on the diff Jan 12, 2015
src/nls/fa-ir/strings.js
"CMD_OPEN_FOLDER" : "باز کردن پوشه\u2026",
"CMD_FILE_CLOSE" : "بستن",
"CMD_FILE_CLOSE_ALL" : "بستن همه",
"CMD_FILE_CLOSE_LIST" : "بستن لیست",
- "CMD_FILE_CLOSE_OTHERS" : "ستن سایر موارد",
+ "CMD_FILE_CLOSE_OTHERS" : "بستن سایر موارد",
@Rezaaa
Rezaaa Jan 12, 2015 Contributor

@datamweb fixed.

@Rezaaa
Contributor
Rezaaa commented Jan 13, 2015

@datamweb so please merge it. thank u.

@datamweb
Contributor

@Rezaaa You've made a lot of errors. Please be resolved.

@Rezaaa
Contributor
Rezaaa commented Jan 13, 2015

@datamweb i solved your misspellings! where is my errors?!

@Mark-Simulacrum
Contributor

@Rezaaa Please check the JSHint log from TravisCI for the list of current linting errors: https://travis-ci.org/adobe/brackets/builds/46781391#L332.

@Rezaaa
Contributor
Rezaaa commented Jan 13, 2015

@Mark-Simulacrum @datamweb the problem is half space character. sorry.

@datamweb
Contributor

@Rezaaa you click on the Details or use @Mark-Simulacrum commented.

@Rezaaa
Contributor
Rezaaa commented Jan 14, 2015

@datamweb is there any problem yet?

@datamweb
Contributor

@Rezaaa thanks for my solved misspellings 👍 .
When I was translating I had used RTL css file of Brackts and there remains the problem. for example: line 175 is false. Because the displays the :شما درحال استفاده از آخرین نسخه {APP_NAME} هستید.
True : .هستید {APP_NAME} شما در حال استفاده از آخرین نسخه
so pleas fix lin 412,420,421and...
do you like the fix?

@Rezaaa
Contributor
Rezaaa commented Jan 15, 2015

@datamweb me@rezamahmoudi.ir Send me an email

@datamweb
Contributor

@Rezaaa ok. Please cheke your email.

@nethip
Contributor
nethip commented Mar 10, 2015

@datamweb Are we good with the translation? Can this be merged?

@datamweb
Contributor

Hi,
@nethip Please wait.
@Rezaaa Please, between lines 319 and 320 add a new line. As follows:
"CMD_TOGGLE_LIVE_PREVIEW_MB_MODE": "Enable Experimental Live Preview",
And then the last line:
/ * Last translated for c292e89 * /
To the
/ * Last translated for eef9c68 * /
Change.

@abose
Contributor
abose commented Apr 15, 2015

@datamweb @Rezaaa Can this translations be merged now?

@datamweb
Contributor

Hi,
@abose ,@RaymondLim please marged.
@Rezaaa thanks for fixing.

@abose abose merged commit 797cee7 into adobe:master Apr 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment