New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to handle protocol-relative URLs from Tern #10647

Merged
merged 1 commit into from Jun 22, 2015

Conversation

Projects
None yet
2 participants
@MarcelGerber
Contributor

MarcelGerber commented Feb 22, 2015

For #10566.

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Mar 5, 2015

@MarcelGerber Does it make sense to move the additional check of filePath.slice(0,2) into FileSystem.isAbsolutepath().

@MarcelGerber Does it make sense to move the additional check of filePath.slice(0,2) into FileSystem.isAbsolutepath().

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Mar 5, 2015

Owner

No, as paths like //server/file.html can point to network folders (AFAIK), but not on the web.

Owner

MarcelGerber replied Mar 5, 2015

No, as paths like //server/file.html can point to network folders (AFAIK), but not on the web.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 19, 2015

Contributor

@nethip Is this change ok with you?

Contributor

MarcelGerber commented Jun 19, 2015

@nethip Is this change ok with you?

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Jun 22, 2015

Contributor

LGTM

Contributor

nethip commented Jun 22, 2015

LGTM

nethip added a commit that referenced this pull request Jun 22, 2015

Merge pull request #10647 from MarcelGerber/tern-protocol-relative-urls
Don't try to handle protocol-relative URLs from Tern

@nethip nethip merged commit fb049f2 into adobe:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:tern-protocol-relative-urls branch Jun 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment