Change 'split selection into lines' shortcut on Linux #10742

Merged
merged 1 commit into from Mar 25, 2015

Projects

None yet

5 participants

@Projjol
Contributor
Projjol commented Mar 14, 2015

Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.

@Projjol Projjol Update keyboard.json
Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.
04bdc94
@peterflynn peterflynn changed the title from Update keyboard.json to Change 'split selection into lines' shortcut on Linux Mar 16, 2015
@peterflynn
Member

Changed to less ambiguous title

@abose abose added the Linux only label Mar 24, 2015
@abose abose commented on the diff Mar 24, 2015
src/base-config/keyboard.json
@@ -71,7 +71,13 @@
}
],
"edit.splitSelIntoLines": [
- "Ctrl-Alt-L"
+ {
+ "key": "Ctrl-Alt-L"
@abose
abose Mar 24, 2015 Contributor

Can we use Ctrl+shift+L in all platforms so that it works uniformly?

@prafulVaishnav
prafulVaishnav Mar 24, 2015 Collaborator

@abose I think we should not change the shortcut key without any strong reasons because users are accustomed to the shortcut keys in Brackets and changing any will not be received gladly by users.

@Projjol
Projjol Mar 24, 2015 Contributor

@prafulVaishnav are you suggesting that it should not be changed for any platform or that it's changed for Linux while the other systems remain the same?

@prksingh
prksingh Mar 25, 2015 Collaborator

@Projjol I think he meant change the shortcut only for linux, which sounds ok to me. I have seen different key bindings for the same command on different platforms in other cases as well (Moving line up / down). So this change should be fine as well

@prksingh prksingh merged commit 46ba092 into adobe:master Mar 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment