New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'split selection into lines' shortcut on Linux #10742

Merged
merged 1 commit into from Mar 25, 2015

Conversation

Projects
None yet
5 participants
@Projjol
Contributor

Projjol commented Mar 14, 2015

Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.

Update keyboard.json
Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.

@peterflynn peterflynn changed the title from Update keyboard.json to Change 'split selection into lines' shortcut on Linux Mar 16, 2015

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Mar 16, 2015

Member

Changed to less ambiguous title

Member

peterflynn commented Mar 16, 2015

Changed to less ambiguous title

@abose abose added the Linux only label Mar 24, 2015

@@ -71,7 +71,13 @@
}
],
"edit.splitSelIntoLines": [
"Ctrl-Alt-L"
{
"key": "Ctrl-Alt-L"

This comment has been minimized.

@abose

abose Mar 24, 2015

Contributor

Can we use Ctrl+shift+L in all platforms so that it works uniformly?

@abose

abose Mar 24, 2015

Contributor

Can we use Ctrl+shift+L in all platforms so that it works uniformly?

This comment has been minimized.

@prafulVaishnav

prafulVaishnav Mar 24, 2015

Contributor

@abose I think we should not change the shortcut key without any strong reasons because users are accustomed to the shortcut keys in Brackets and changing any will not be received gladly by users.

@prafulVaishnav

prafulVaishnav Mar 24, 2015

Contributor

@abose I think we should not change the shortcut key without any strong reasons because users are accustomed to the shortcut keys in Brackets and changing any will not be received gladly by users.

This comment has been minimized.

@Projjol

Projjol Mar 24, 2015

Contributor

@prafulVaishnav are you suggesting that it should not be changed for any platform or that it's changed for Linux while the other systems remain the same?

@Projjol

Projjol Mar 24, 2015

Contributor

@prafulVaishnav are you suggesting that it should not be changed for any platform or that it's changed for Linux while the other systems remain the same?

This comment has been minimized.

@prksingh

prksingh Mar 25, 2015

Contributor

@Projjol I think he meant change the shortcut only for linux, which sounds ok to me. I have seen different key bindings for the same command on different platforms in other cases as well (Moving line up / down). So this change should be fine as well

@prksingh

prksingh Mar 25, 2015

Contributor

@Projjol I think he meant change the shortcut only for linux, which sounds ok to me. I have seen different key bindings for the same command on different platforms in other cases as well (Moving line up / down). So this change should be fine as well

prksingh added a commit that referenced this pull request Mar 25, 2015

Merge pull request #10742 from Projjol/patch-1
Change 'split selection into lines' shortcut on Linux

@prksingh prksingh merged commit 46ba092 into adobe:master Mar 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment