New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeMirror #11071

Merged
merged 3 commits into from May 13, 2015

Conversation

Projects
None yet
2 participants
@MarcelGerber
Contributor

MarcelGerber commented May 9, 2015

Closes #10921.

I've run all unit tests without errors and also Smoke Tests, where 3 steps failed (2 (Multi Browser) Live Preview, 1 Inline Editor), but they also fail on master. I'll see whether they are already filed and file them if not.

CodeMirror releases page
Commit log

@MarcelGerber MarcelGerber referenced this pull request May 9, 2015

Closed

Update CodeMirror #10921

@prafulVaishnav

This comment has been minimized.

Show comment
Hide comment
@prafulVaishnav

prafulVaishnav May 13, 2015

Contributor

Fix for the change in CodeMirror commit.
LGTM. Merging.
@MarcelGerber Thanks..

Contributor

prafulVaishnav commented May 13, 2015

Fix for the change in CodeMirror commit.
LGTM. Merging.
@MarcelGerber Thanks..

prafulVaishnav added a commit that referenced this pull request May 13, 2015

@prafulVaishnav prafulVaishnav merged commit 463547e into master May 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prafulVaishnav prafulVaishnav deleted the marcel/cm-update branch May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment