Italian translation review #11117
Italian translation review #11117
Conversation
Finally there to start the review
41: if brackets one day might support other that utf-8 it's ok, else drop: ```Attualmente ```
71: now {0} is used for the file name and {1} for the following chars, general information updated
add 'directory' (cartella) on line 35, 36 and 42, I see in other languages those strings are used both for file and directory
on line 72 I see ```"FILE_ALREADY_EXISTS"```, in the root (and other langs) file that string does not exist. Instead I have ```"ENTRY_WITH_SAME_NAME_EXISTS"```
|
Now it's the other way round: |
|
Looks good to me. |
|
Looks good to me. @marcelgerber can merge! |
| @@ -68,8 +68,8 @@ define({ | |||
| "ERROR_DELETING_FILE_TITLE" : "Errore durante il tentativo di eliminazione del file", | |||
| "ERROR_DELETING_FILE" : "Errore durante il tentativo di eliminazione del file <span class='dialog-filename'>{0}</span>. {1}", | |||
| "INVALID_FILENAME_TITLE" : "Il nome del file non è valido", | |||
| "INVALID_FILENAME_MESSAGE" : "Il nome del file non può contenere i seguenti caratteri: {0}", | |||
| "FILE_ALREADY_EXISTS" : "Il file <span class='dialog-filename'>{0}</span> esiste già.", | |||
| "INVALID_FILENAME_MESSAGE" : "Il nome {0} non può usare caratteri di sistema riservati, finire con un punto (.) o contenere i seguenti caratteri: <code class='emphasized'>{1}</code>", | |||
There was a problem hiding this comment.
I don't think that's the expected outcome. ({0} is replaced with either Nomi dei file or Nomi cartelle).
If you can't make it work with the strings available (our nls resources are sadly still very English-oriented and thus, it's not always easy to make translations work), try something like Name of file/folder translated to Italian.
There was a problem hiding this comment.
INVALID_FILENAME_MESSAGEshould becomeI {0} non possono usare caratteri di sistema riservati, finire con un punto (.) o contenere i seguenti caratteri: <code class='emphasized'>{1}</code>DIRECTORY_NAMES_LEDEshould becomenomi delle cartelleFILENAMES_LEDEshould becomenomi dei file
Fixed placeholder errors
|
@nicolo-ribaudo sounds good to me, merged! |
Italian translation review
|
Thanks, merged! |
|
At some point or another (it's usually best just before releasing a new version), you should also update your translation with the latest changes you find here: 68793ab...master#diff-4a1c7e72fe8e80ae96d46411322384c8 Please make sure to also update the SHA comment at the end of the file, too, as it looks like it hasn't been updated for a long time ;) |
|
@marcelgerber the review is not over, in the next days I continue push. At the end of the review I also update the SHA comment. |
|
Every two months I'd say, but for the last few releases varied a lot. See https://marcelgerber.github.io/brackets-changelog.html for the exact dates. |
|
I already merged this PR, so for further updates/improvements please open a new PR. It's probably best to mention Denis and Nicolò right from the first post so they can start review early. |
|
Thanks to you for the advices , I'll tag Denis and Nicolò for the next PR and I'll put [WIP] on the title. |
Finally there to start the review
41: if brackets one day might support other that utf-8 it's ok, else drop:
Attualmente71: now {0} is used for the file name and {1} for the following chars, general information updated