New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation review #11117

Merged
merged 5 commits into from May 16, 2015

Conversation

Projects
None yet
4 participants
@Fredev
Contributor

Fredev commented May 15, 2015

Finally there to start the review

41: if brackets one day might support other that utf-8 it's ok, else drop: Attualmente
71: now {0} is used for the file name and {1} for the following chars, general information updated

Fredev added some commits May 15, 2015

Italian translation review
Finally there to start the review

41: if brackets one day might support other that utf-8 it's ok, else drop: ```Attualmente ```
71: now {0} is used for the file name and {1} for the following chars, general information updated
Fixed file and directory error strings
add 'directory' (cartella) on line 35, 36 and 42, I see in other languages those strings are used both for file and directory
Add entry with same name exists error string
on line 72 I see ```"FILE_ALREADY_EXISTS"```, in the root (and other langs) file that string does not exist. Instead I have ```"ENTRY_WITH_SAME_NAME_EXISTS"```
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 15, 2015

Contributor

Now it's the other way round:
@Denisov21 @nicolo-ribaudo Would you mind having a look at this?

Contributor

MarcelGerber commented May 15, 2015

Now it's the other way round:
@Denisov21 @nicolo-ribaudo Would you mind having a look at this?

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo May 15, 2015

Contributor

Looks good to me.

Contributor

nicolo-ribaudo commented May 15, 2015

Looks good to me.

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 May 15, 2015

Contributor

Looks good to me. @MarcelGerber can merge!

Contributor

Denisov21 commented May 15, 2015

Looks good to me. @MarcelGerber can merge!

@MarcelGerber

View changes

Show outdated Hide outdated src/nls/it/strings.js
@@ -68,8 +68,8 @@ define({
"ERROR_DELETING_FILE_TITLE" : "Errore durante il tentativo di eliminazione del file",
"ERROR_DELETING_FILE" : "Errore durante il tentativo di eliminazione del file <span class='dialog-filename'>{0}</span>. {1}",
"INVALID_FILENAME_TITLE" : "Il nome del file non è valido",
"INVALID_FILENAME_MESSAGE" : "Il nome del file non può contenere i seguenti caratteri: {0}",
"FILE_ALREADY_EXISTS" : "Il file <span class='dialog-filename'>{0}</span> esiste già.",
"INVALID_FILENAME_MESSAGE" : "Il nome {0} non può usare caratteri di sistema riservati, finire con un punto (.) o contenere i seguenti caratteri: <code class='emphasized'>{1}</code>",

This comment has been minimized.

@MarcelGerber

MarcelGerber May 15, 2015

Contributor

image
I don't think that's the expected outcome. ({0} is replaced with either Nomi dei file or Nomi cartelle).

If you can't make it work with the strings available (our nls resources are sadly still very English-oriented and thus, it's not always easy to make translations work), try something like Name of file/folder translated to Italian.

@MarcelGerber

MarcelGerber May 15, 2015

Contributor

image
I don't think that's the expected outcome. ({0} is replaced with either Nomi dei file or Nomi cartelle).

If you can't make it work with the strings available (our nls resources are sadly still very English-oriented and thus, it's not always easy to make translations work), try something like Name of file/folder translated to Italian.

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo May 16, 2015

Contributor
  • INVALID_FILENAME_MESSAGE should become I {0} non possono usare caratteri di sistema riservati, finire con un punto (.) o contenere i seguenti caratteri: <code class='emphasized'>{1}</code>
  • DIRECTORY_NAMES_LEDE should become nomi delle cartelle
  • FILENAMES_LEDE should become nomi dei file
@nicolo-ribaudo

nicolo-ribaudo May 16, 2015

Contributor
  • INVALID_FILENAME_MESSAGE should become I {0} non possono usare caratteri di sistema riservati, finire con un punto (.) o contenere i seguenti caratteri: <code class='emphasized'>{1}</code>
  • DIRECTORY_NAMES_LEDE should become nomi delle cartelle
  • FILENAMES_LEDE should become nomi dei file
@MarcelGerber

View changes

Show outdated Hide outdated src/nls/it/strings.js
@@ -68,8 +68,8 @@ define({
"ERROR_DELETING_FILE_TITLE" : "Errore durante il tentativo di eliminazione del file",
"ERROR_DELETING_FILE" : "Errore durante il tentativo di eliminazione del file <span class='dialog-filename'>{0}</span>. {1}",
"INVALID_FILENAME_TITLE" : "Il nome del file non è valido",

This comment has been minimized.

@MarcelGerber

MarcelGerber May 15, 2015

Contributor

Please try to use {0} instead of del file here, or try the solution described above otherwise.

@MarcelGerber

MarcelGerber May 15, 2015

Contributor

Please try to use {0} instead of del file here, or try the solution described above otherwise.

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo May 16, 2015

Contributor
  • INVALID_FILENAME_TITLE should become Il {0} non è valido
  • DIRECTORY_NAME should become nome della cartella
  • FILENAME should become nome del file
@nicolo-ribaudo

nicolo-ribaudo May 16, 2015

Contributor
  • INVALID_FILENAME_TITLE should become Il {0} non è valido
  • DIRECTORY_NAME should become nome della cartella
  • FILENAME should become nome del file
@Fredev

This comment has been minimized.

Show comment
Hide comment
@Fredev

Fredev May 16, 2015

Contributor

@nicolo-ribaudo sounds good to me, merged!

Contributor

Fredev commented May 16, 2015

@nicolo-ribaudo sounds good to me, merged!

MarcelGerber added a commit that referenced this pull request May 16, 2015

@MarcelGerber MarcelGerber merged commit d838187 into adobe:master May 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 16, 2015

Contributor

Thanks, merged!

Contributor

MarcelGerber commented May 16, 2015

Thanks, merged!

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 16, 2015

Contributor

At some point or another (it's usually best just before releasing a new version), you should also update your translation with the latest changes you find here: 68793ab...masterdiff-4a1c7e72fe8e80ae96d46411322384c8

Please make sure to also update the SHA comment at the end of the file, too, as it looks like it hasn't been updated for a long time ;)

Contributor

MarcelGerber commented May 16, 2015

At some point or another (it's usually best just before releasing a new version), you should also update your translation with the latest changes you find here: 68793ab...masterdiff-4a1c7e72fe8e80ae96d46411322384c8

Please make sure to also update the SHA comment at the end of the file, too, as it looks like it hasn't been updated for a long time ;)

@Fredev

This comment has been minimized.

Show comment
Hide comment
@Fredev

Fredev May 16, 2015

Contributor

@MarcelGerber the review is not over, in the next days I continue push. At the end of the review I also update the SHA comment.
how often comes a new version of Brackets?

Contributor

Fredev commented May 16, 2015

@MarcelGerber the review is not over, in the next days I continue push. At the end of the review I also update the SHA comment.
how often comes a new version of Brackets?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 16, 2015

Contributor

Every two months I'd say, but for the last few releases varied a lot. See https://marcelgerber.github.io/brackets-changelog.html for the exact dates.

Contributor

MarcelGerber commented May 16, 2015

Every two months I'd say, but for the last few releases varied a lot. See https://marcelgerber.github.io/brackets-changelog.html for the exact dates.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 16, 2015

Contributor

I already merged this PR, so for further updates/improvements please open a new PR. It's probably best to mention Denis and Nicolò right from the first post so they can start review early.
You can also mark your PR "[WIP]" (Work in Progress) or "[REVIEW ONLY]" (put one of those in the title) if you don't want it to be merged yet.
Thanks!

Contributor

MarcelGerber commented May 16, 2015

I already merged this PR, so for further updates/improvements please open a new PR. It's probably best to mention Denis and Nicolò right from the first post so they can start review early.
You can also mark your PR "[WIP]" (Work in Progress) or "[REVIEW ONLY]" (put one of those in the title) if you don't want it to be merged yet.
Thanks!

@Fredev

This comment has been minimized.

Show comment
Hide comment
@Fredev

Fredev May 16, 2015

Contributor

Thanks to you for the advices , I'll tag Denis and Nicolò for the next PR and I'll put [WIP] on the title.

Contributor

Fredev commented May 16, 2015

Thanks to you for the advices , I'll tag Denis and Nicolò for the next PR and I'll put [WIP] on the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment