New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate in Italian for Brackets 1.4 #11318

Merged
merged 5 commits into from Jul 13, 2015

Conversation

Projects
None yet
5 participants
@Denisov21
Contributor

Denisov21 commented Jun 27, 2015

Translate in Italian for Brackets 1.4

Update strings.js
Translate in Italian for Brackets 1.4

@Denisov21 Denisov21 changed the title from Update strings.js to Translate in Italian for Brackets 1.4 Jun 27, 2015

@MarcelGerber MarcelGerber added this to the Release 1.4 milestone Jun 29, 2015

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 29, 2015

Contributor

@nicolo-ribaudo Would you mind doing a quick review for these changes?

Contributor

MarcelGerber commented Jun 29, 2015

@nicolo-ribaudo Would you mind doing a quick review for these changes?

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jun 29, 2015

Contributor

Done

Contributor

nicolo-ribaudo commented Jun 29, 2015

Done

@Fredev

This comment has been minimized.

Show comment
Hide comment
@Fredev

Fredev Jun 29, 2015

Contributor

@nicolo-ribaudo I started review the comments :)

Contributor

Fredev commented Jun 29, 2015

@nicolo-ribaudo I started review the comments :)

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jun 29, 2015

Contributor

I've translated some JSLint-related strings differently from nls/root/strings.js to make them clearer.

Contributor

nicolo-ribaudo commented Jun 29, 2015

I've translated some JSLint-related strings differently from nls/root/strings.js to make them clearer.

@Fredev

This comment has been minimized.

Show comment
Hide comment
@Fredev

Fredev Jun 29, 2015

Contributor

good translation for me!

Contributor

Fredev commented Jun 29, 2015

good translation for me!

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Jun 29, 2015

Contributor

Good for me!

Contributor

Denisov21 commented Jun 29, 2015

Good for me!

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jun 30, 2015

Contributor

@Denisov21 I've corrected these errors: Denisov21/brackets#1

Contributor

nicolo-ribaudo commented Jun 30, 2015

@Denisov21 I've corrected these errors: Denisov21/brackets#1

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Jul 1, 2015

Contributor

I think @nicolo-ribaudo can close this PR becouse @MarcelGerber merge this PR (#11117).

Contributor

Denisov21 commented Jul 1, 2015

I think @nicolo-ribaudo can close this PR becouse @MarcelGerber merge this PR (#11117).

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jul 1, 2015

Contributor

That PR was about other strings

Contributor

nicolo-ribaudo commented Jul 1, 2015

That PR was about other strings

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jul 12, 2015

Contributor

@Denisov21 @nicolo-ribaudo @Fredev @MarcelGerber
Is this PR ready to be merged?

Contributor

abose commented Jul 12, 2015

@Denisov21 @nicolo-ribaudo @Fredev @MarcelGerber
Is this PR ready to be merged?

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jul 12, 2015

Contributor

No, because @Denisov21 hasn't merged Denisov21/brackets#1yet.

Contributor

nicolo-ribaudo commented Jul 12, 2015

No, because @Denisov21 hasn't merged Denisov21/brackets#1yet.

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Jul 12, 2015

Contributor

Scusa @nicolo-ribaudo che cosa significa "No, because @Denisov21 hasn't merged Denisov21/brackets#1yet ? Io non posso unire nulla!

Contributor

Denisov21 commented Jul 12, 2015

Scusa @nicolo-ribaudo che cosa significa "No, because @Denisov21 hasn't merged Denisov21/brackets#1yet ? Io non posso unire nulla!

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jul 12, 2015

Contributor

@Denisov21 You should merge Denisov21/brackets#1 . Here is a guide on how to merge a pr: https://help.github.com/articles/merging-a-pull-request/


Italian translation:
Dovresti unire Denisov21/brackets#1 . Ecco una guida su come fare: https://help.github.com/articles/merging-a-pull-request/.
Quella PR contiene le correzioni delle tue traduzioni, ma non vengono applicate finché non clicchi sul bottone 'Merge pull request'

Contributor

nicolo-ribaudo commented Jul 12, 2015

@Denisov21 You should merge Denisov21/brackets#1 . Here is a guide on how to merge a pr: https://help.github.com/articles/merging-a-pull-request/


Italian translation:
Dovresti unire Denisov21/brackets#1 . Ecco una guida su come fare: https://help.github.com/articles/merging-a-pull-request/.
Quella PR contiene le correzioni delle tue traduzioni, ma non vengono applicate finché non clicchi sul bottone 'Merge pull request'

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jul 12, 2015

Contributor

@abose @MarcelGerber Now this pr can be merged

Contributor

nicolo-ribaudo commented Jul 12, 2015

@abose @MarcelGerber Now this pr can be merged

@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Jul 12, 2015

Contributor

There should be a comma at the end of line 650

Contributor

nicolo-ribaudo commented Jul 12, 2015

There should be a comma at the end of line 650

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Jul 12, 2015

Contributor

@nicolo-ribaudo I've done! I merge with success. Thank @nicolo-ribaudo very much!

Contributor

Denisov21 commented Jul 12, 2015

@nicolo-ribaudo I've done! I merge with success. Thank @nicolo-ribaudo very much!

@sprintr sprintr referenced this pull request Jul 13, 2015

Merged

Fixed a few typos #11302

abose added a commit that referenced this pull request Jul 13, 2015

Merge pull request #11318 from Denisov21/patch-38
Translate in Italian for Brackets 1.4

@abose abose merged commit ddcbe93 into adobe:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jul 13, 2015

Contributor

@Denisov21 @nicolo-ribaudo @Fredev Thanks everyone for the quick changes.
Merging.

Contributor

abose commented Jul 13, 2015

@Denisov21 @nicolo-ribaudo @Fredev Thanks everyone for the quick changes.
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment