This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make font settings react to pref changes #11190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,10 @@ define(function (require, exports, module) { | |||
|
|
|||
| var prefs = PreferencesManager.getExtensionPrefs("fonts"); | |||
|
|
|||
| // These variables contain the preference values. They are used to no-op in case nothing changed | |||
| // and updated *after* the call to setFontSize/setFontFamily. | |||
| var fontSizeValue, fontFamilyValue; | |||
There was a problem hiding this comment.
Let's add proper jsdoc to these two variables and mark them as private.
|
@marcelgerber changes look good. I am not even sure why I didn't add this with the initial PR, so thanks :) |
|
@marcelgerber thanks for this change! I just have a s comment. Can we change the variable name to something like currFontSizeValue. I guess it would improve the readability of the code. Otherwise LGTM. |
|
Changes pushed. |
|
looks good, works well. merging in. |
MiguelCastillo
added a commit
that referenced
this pull request
Jun 1, 2015
Make font settings react to pref changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should go with, or before, #11130.