Make font settings react to pref changes #11190

Merged
merged 2 commits into from Jun 1, 2015

Projects

None yet

4 participants

@MarcelGerber
Member

This should go with, or before, #11130.

@MiguelCastillo MiguelCastillo commented on an outdated diff May 31, 2015
src/view/ViewCommandHandlers.js
@@ -49,6 +49,10 @@ define(function (require, exports, module) {
var prefs = PreferencesManager.getExtensionPrefs("fonts");
+ // These variables contain the preference values. They are used to no-op in case nothing changed
+ // and updated *after* the call to setFontSize/setFontFamily.
+ var fontSizeValue, fontFamilyValue;
@MiguelCastillo
MiguelCastillo May 31, 2015 Member

Let's add proper jsdoc to these two variables and mark them as private.

@MiguelCastillo
Member

@MarcelGerber changes look good. I am not even sure why I didn't add this with the initial PR, so thanks :)

@nethip
Contributor
nethip commented Jun 1, 2015

@MarcelGerber thanks for this change! I just have a s comment. Can we change the variable name to something like currFontSizeValue. I guess it would improve the readability of the code. Otherwise LGTM.

@abose abose added this to the Release 1.4 milestone Jun 1, 2015
@MarcelGerber
Member

Changes pushed.

@MiguelCastillo
Member

looks good, works well. merging in.

@MiguelCastillo MiguelCastillo merged commit 83b632d into master Jun 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose abose deleted the marcel/fonts-react-prefs branch Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment