New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeMirror simple-mode addon #11280

Merged
merged 1 commit into from Jun 19, 2015

Conversation

Projects
None yet
4 participants
@sprintr
Contributor

sprintr commented Jun 15, 2015

Allows extension developers to use CodeMirror's simple mode addon. Fixes #11267 and #10501

@mackenza

This comment has been minimized.

Show comment
Hide comment
@mackenza

mackenza Jun 15, 2015

Contributor

@sprintr have you tried adding a simple mode as a new language in Brackets with this?

Contributor

mackenza commented Jun 15, 2015

@sprintr have you tried adding a simple mode as a new language in Brackets with this?

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 15, 2015

Contributor

@mackenza Yes, I added CodeMirror's handlebars mode as a language to brackets. It worked fine when I tested it against some handlebars strings.

Contributor

sprintr commented Jun 15, 2015

@mackenza Yes, I added CodeMirror's handlebars mode as a language to brackets. It worked fine when I tested it against some handlebars strings.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 19, 2015

Contributor

This looks good. All unit and integration tests passed.

Merging. Thanks for this awesome contribution!

Contributor

MarcelGerber commented Jun 19, 2015

This looks good. All unit and integration tests passed.

Merging. Thanks for this awesome contribution!

MarcelGerber added a commit that referenced this pull request Jun 19, 2015

@MarcelGerber MarcelGerber merged commit 7793f40 into adobe:master Jun 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcelGerber MarcelGerber added this to the Release 1.4 milestone Jun 19, 2015

@sprintr sprintr deleted the sprintr:cm-simplemode-addon branch Jun 19, 2015

@foice

This comment has been minimized.

Show comment
Hide comment
@foice

foice Aug 7, 2015

Great, your edit of the Language-Support page is already a first step, but to me it still sounds greek.

"To use your custom CodeMirror mode, load it using require(), register it with CodeMirror using CodeMirror.defineMode(), then call LanguageManager.defineLanguage() as above."

maybe it says it all, but only if you know the lingo ... :P

Would it be possible to have a more step by step help page to add a new language from scratch?

At this point such a feature might be a great thing that bracket does, so it is probably worth explaining to the people :)

Thanks a lot
Roberto

foice commented Aug 7, 2015

Great, your edit of the Language-Support page is already a first step, but to me it still sounds greek.

"To use your custom CodeMirror mode, load it using require(), register it with CodeMirror using CodeMirror.defineMode(), then call LanguageManager.defineLanguage() as above."

maybe it says it all, but only if you know the lingo ... :P

Would it be possible to have a more step by step help page to add a new language from scratch?

At this point such a feature might be a great thing that bracket does, so it is probably worth explaining to the people :)

Thanks a lot
Roberto

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Aug 10, 2015

Contributor

@foice Tracked as issue #11573.
Please head over there for any further suggestions

Contributor

MarcelGerber commented Aug 10, 2015

@foice Tracked as issue #11573.
Please head over there for any further suggestions

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Aug 10, 2015

Contributor

I have answered about @foice's issue in the brackets-dev group.

@MarcelGerber We can add a couple of examples of using defineMode and defineSimpleMode to the language support wiki page.

Contributor

sprintr commented Aug 10, 2015

I have answered about @foice's issue in the brackets-dev group.

@MarcelGerber We can add a couple of examples of using defineMode and defineSimpleMode to the language support wiki page.

@foice

This comment has been minimized.

Show comment
Hide comment
@foice

foice Aug 10, 2015

Yes I am looking now at Amin Ullah Khan main.js. It looks promising and will give it a try tomorrow.
Thanks to Amin Ullah Khan for sharing and to all of your for the support.

foice commented Aug 10, 2015

Yes I am looking now at Amin Ullah Khan main.js. It looks promising and will give it a try tomorrow.
Thanks to Amin Ullah Khan for sharing and to all of your for the support.

@foice

This comment has been minimized.

Show comment
Hide comment
@foice

foice Aug 11, 2015

The example provided was very helpful. I think I have gone already a good way in coloring my code :)
Will think about extended features and maybe come back if I do not find documentation.
Cheers

foice commented Aug 11, 2015

The example provided was very helpful. I think I have gone already a good way in coloring my code :)
Will think about extended features and maybe come back if I do not find documentation.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment