Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Code folding unit tests #11584

Merged
merged 7 commits into from
Oct 15, 2015
Merged

Conversation

thehogfather
Copy link
Contributor

Ref: #10893
Some simple tests for code-folding. Specifically it tests the following:

  1. Gutter fold marks are rendered on startup
  2. Folding code creates a folded region in editor
  3. Expanding code clears the folded region in editor
  4. Clearing the text marker on folded region expands it and updates the fold gutter
  5. Folded lines have a folded (i.e., closed) marker in the gutter
  6. Foldable lines have a foldable (i.e., open) marker in the gutter
  7. Persistence of fold states work as expected - i.e., fold states are saved and restored when persistence is enabled
  8. Persistence of fold states can be disabled
  9. Minimum fold size is obeyed
  10. Code folding can be disabled
  11. Selecting text does not trigger fold marks when `makeSelectionsFoldable' is disabled
  12. Selecting text triggers fold marks when `makeSelectionsFoldable' is enabled
  13. Successively selecting text only triggers fold region for the last selection

…html elements where the starttag spans more than one line now works correctly.
@nethip
Copy link
Contributor

nethip commented Aug 13, 2015

@thehogfather Thanks for this PR! Really appreciate it. @abose @marcelgerber @sprintr Would you guys mind taking a look at this PR.

…-11356

Conflicts:
	src/extensions/default/CodeFolding/foldhelpers/foldgutter.js
…folding-unit-tests

Conflicts:
	src/extensions/default/CodeFolding/unittests.js
* issue-11356:
  addresses adobe#11356 collapsing and expanding fold ranges in xml or html elements where the starttag spans more than one line now works correctly.
@abose abose added this to the Release 1.6 milestone Oct 14, 2015
@abose
Copy link
Contributor

abose commented Oct 14, 2015

@thehogfather Sorry , missed this PR for the release.
Could you resolve the merge conflicts?

@thehogfather
Copy link
Contributor Author

done.

@abose
Copy link
Contributor

abose commented Oct 15, 2015

Thanks @thehogfather .
verified all unit tests passing. Merging.

abose added a commit that referenced this pull request Oct 15, 2015
@abose abose merged commit fe524fc into adobe:master Oct 15, 2015
@thehogfather thehogfather deleted the code-folding-unit-tests branch August 10, 2016 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants