This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix for #3296: add deprecation warning for global Mustache #11616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ficristo Would you mind resolving the conflicts? Thanks. |
|
@ingorichter I have updated the patch. |
|
@ingorichter I've rebased the patch. |
|
@marcelgerber could you review this? |
|
LGTM. Only minor thing is that you should be able to remove Line 277 in 656a0ee |
|
@marcelgerber done. |
|
Thank you! |
This was referenced Aug 29, 2021
[CLOSED] Load Mustache with require in each module that uses it
brackets-archive/bracketsIssues#3099
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some references in test/perf/OpenFile-perf-files/brackets-concat.js, but the file seemed autogenerated so I didn't changed it.
#3296