Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Do not run jshint tasks twice #11664

Merged
merged 4 commits into from
Sep 8, 2015
Merged

Do not run jshint tasks twice #11664

merged 4 commits into from
Sep 8, 2015

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Sep 5, 2015

Small cleanup.

@nethip
Copy link
Contributor

nethip commented Sep 8, 2015

Thanks @ficristo ! Looks good. Merging.

nethip added a commit that referenced this pull request Sep 8, 2015
Do not run jshint tasks twice
@nethip nethip merged commit 81925ce into adobe:master Sep 8, 2015
@ficristo ficristo deleted the jshint-once branch September 8, 2015 18:36
@le717
Copy link
Contributor

le717 commented Sep 8, 2015

The :all subtask was present to run all the test suites (src, test, and grunt) all at one time instead of having to run each one individually. With this change, did you confirm running grunt test runs all the suites like before? Also, how were the JSHint subtasks being run twice as there was only one call to run them (jshint:all)?

@ficristo
Copy link
Collaborator Author

@le717 If you omit the subtask ("all" in this case) jshint run all the tasks defined.
This change impact who run jshint alone (so they do not need to remember the subtask), and the "watch:all" task that now do not run jshint twice.
I confirm that |grunt test| run the same suites as before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants