Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Remove .jsx from Javascript file extensions and create an jsx-mode #12052

Merged
merged 1 commit into from
May 13, 2016

Conversation

petetnt
Copy link
Collaborator

@petetnt petetnt commented Jan 5, 2016

This PR removes .jsx from Javascript file extensions and creates an separate jsx-mode.

@MiguelCastillo
Copy link
Contributor

@petetnt we have used the convention in the past to put in the title of the PR "[DO NOT MERGE]" or something to that extent for a more visual cue of the status of the PR.

Correction. I think the convention was "[REVIEW ONLY]"... :)

@MiguelCastillo
Copy link
Contributor

Looking forward to this :)

@petetnt petetnt changed the title Remove .jsx from Javascript file extensions and create an jsx-mode [DO NOT MERGE] Remove .jsx from Javascript file extensions and create an jsx-mode Feb 13, 2016
@petetnt petetnt changed the title [DO NOT MERGE] Remove .jsx from Javascript file extensions and create an jsx-mode [REVIEW ONLY] Remove .jsx from Javascript file extensions and create an jsx-mode Feb 13, 2016
@petetnt
Copy link
Collaborator Author

petetnt commented Feb 13, 2016

@MiguelCastillo Yeah that's probably a good idea. I changed the title 👍

@MiguelCastillo
Copy link
Contributor

I created and added a label to track PRs that shouldn't be merged. :) Easier to filter

@petetnt petetnt changed the title [REVIEW ONLY] Remove .jsx from Javascript file extensions and create an jsx-mode Remove .jsx from Javascript file extensions and create an jsx-mode Apr 6, 2016
@petetnt
Copy link
Collaborator Author

petetnt commented Apr 6, 2016

CodeMirror is now merged so this should be too. Ping @MiguelCastillo

@MiguelCastillo
Copy link
Contributor

@petetnt Yup - this is my next item on the list :)

@marcelgerber
Copy link
Contributor

I think this is an easy merge now. Is there something blocking this, @MiguelCastillo @petetnt?

@petetnt
Copy link
Collaborator Author

petetnt commented May 13, 2016

@marcelgerber nope AFAIK. Just needed the CodeMirror update. Cannot remove the do not merge tag myself but there shouldn't be anything to stop merging this, actually merging this would be really beneficial 💰

@MiguelCastillo
Copy link
Contributor

Yeah you guys are right. I completely disappeared for a bit and neglected. Merging now.

@MiguelCastillo MiguelCastillo merged commit 4eb3071 into adobe:master May 13, 2016
@MiguelCastillo
Copy link
Contributor

It works very nicely too! Thank you @petetnt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants