Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Some unit test fixes #12437

Merged
merged 3 commits into from
May 20, 2016
Merged

Some unit test fixes #12437

merged 3 commits into from
May 20, 2016

Conversation

marcelgerber
Copy link
Contributor

@marcelgerber marcelgerber commented May 19, 2016 •
edited
Loading

Fixes the test failures we see on current master for ProjectModel (Unit), ExtensionManager (Unit) and CSS Code Hints (Extensions).

See the individual commit messages for more information.

Marcel Gerber added 3 commits May 19, 2016 23:53
Fix ProjectModel test 'adjusts the selection if a parent folder is re…
a9c4b8c 
…named'

Test failure caused by a505026
Fix Extension Manager test failures
ce12a86 
Caused by interference between #12389 and #12203.
The former utilizes PathUtils, while the latter adapted PathUtils
to our normal require() workflow.
Fix CSS Code Hints test case 'should show color swatches for backgrou…
bc00259 
…nd-color'

Caused by our recent CEF upgrade
@nethip
Copy link
Contributor

nethip commented May 20, 2016

Thanks for fixing these @marcelgerber . These changes look good to me.

@nethip nethip merged commit c8a403b into master May 20, 2016
@marcelgerber marcelgerber deleted the marcel/test-fixes branch May 20, 2016 07:14
@ficristo
Copy link
Collaborator

@marcelgerber do you know why the ProjectModel tests needed to be changed?

@ficristo ficristo mentioned this pull request May 20, 2016
Closed
@marcelgerber
Copy link
Contributor Author

It's because of this newly introduced change: a505026#diff-d93c1799d928e189223d1d4fa75f80dcR816.
Our isWithinProject check works by checking if the file/folder path (/foo before this change) begins with the project root path (/foo/).
I made sure that every path we pass to the function has a trailing /, so this doesn't cause any problems.

@ficristo
Copy link
Collaborator

Thank you!

This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelgerber @nethip @ficristo