This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Caching $(".modal-body", $dlg) in to its own variable #12805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaggino
suggested changes
Sep 28, 2016
There was a problem hiding this comment.
@mansimarkaur this is good, but I think it misses two lines @darkcoderrises added in #11378 which @ficristo reviewed ... the PR as it is, won't fix #10611 by itself, will it?
|
@zaggino I'm sorry. I assumed his PR was merged. I should've checked. I've added the required changes in the above commit. |
zaggino
approved these changes
Sep 28, 2016
|
@ficristo can you review this since you've looked at this before? |
|
I never looked closely at it. I'll see if I can take a look at the weekend. |
|
Merged, thanks for the PR @mansimarkaur |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10611