Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Caching $(".modal-body", $dlg) in to its own variable #12805

Merged
merged 2 commits into from
Sep 28, 2016
Merged

Caching $(".modal-body", $dlg) in to its own variable #12805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7d64d
added variable for modal-body in context
mansimarkaur Sep 27, 2016
b407256
Added scrollTop in Extension Manager
mansimarkaur Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/extensibility/ExtensionManagerDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ define(function (require, exports, module) {
views = [],
$search,
$searchClear,
$modalDlg,
context = { Strings: Strings, showRegistry: !!brackets.config.extension_registry },
models = [];

Expand All @@ -335,6 +336,7 @@ define(function (require, exports, module) {
$search.val("");
views.forEach(function (view, index) {
view.filter("");
$modalDlg.scrollTop(0);
});

if (!updateSearchDisabled()) {
Expand All @@ -360,14 +362,15 @@ define(function (require, exports, module) {
$dlg = dialog.getElement();
$search = $(".search", $dlg);
$searchClear = $(".search-clear", $dlg);
$modalDlg = $(".modal-body", $dlg);

function setActiveTab($tab) {
if (models[_activeTabIndex]) {
models[_activeTabIndex].scrollPos = $(".modal-body", $dlg).scrollTop();
models[_activeTabIndex].scrollPos = $modalDlg.scrollTop();
}
$tab.tab("show");
if (models[_activeTabIndex]) {
$(".modal-body", $dlg).scrollTop(models[_activeTabIndex].scrollPos || 0);
$modalDlg.scrollTop(models[_activeTabIndex].scrollPos || 0);
clearSearch();
}
}
Expand Down Expand Up @@ -434,7 +437,7 @@ define(function (require, exports, module) {
$(".spinner", $dlg).remove();

views.forEach(function (view) {
view.$el.appendTo($(".modal-body", $dlg));
view.$el.appendTo($modalDlg);
});

// Update search UI before new tab is shown
Expand All @@ -454,6 +457,7 @@ define(function (require, exports, module) {
var query = $(this).val();
views.forEach(function (view) {
view.filter(query);
$modalDlg.scrollTop(0);
});
}).on("click", ".search-clear", clearSearch);

Expand Down