This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix for Title bar text and Save button issue for empty active pane #14421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sobisht
commented
Jun 13, 2018
sobisht
commented
- _updateTitle() failed when there is no file opened in active pane. Causing the title bar retaining the text of last opened document as title. Added a null check for that.
- _setMenuItemsVisible() failed when there is no file opened in active pane. Causing the state of file menu options same as for previous file. Added a check to enable menu options if no file is present in active pane.
boopeshmahendran
approved these changes
Jun 13, 2018
navch
reviewed
Jun 13, 2018
| @@ -158,8 +158,8 @@ define(function (require, exports, module) { | |||
| var currentDoc = DocumentManager.getCurrentDocument(), | |||
| windowTitle = brackets.config.app_title, | |||
| currentlyViewedFile = MainViewManager.getCurrentlyViewedFile(MainViewManager.ACTIVE_PANE), | |||
| currentlyViewedPath = currentlyViewedFile.fullPath, | |||
There was a problem hiding this comment.
Good fix 👍 Actually one console error was there because of this line on project change. Can you please verify that as well?
There was a problem hiding this comment.
Yes, this will fix the console error also.
navch
approved these changes
Jun 13, 2018
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.