This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update live preview icon for any document that does not have .css extens... #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension. Also update it only if live preview is on.
ghost
assigned 
|
Reviewing |
| @@ -331,7 +322,8 @@ define(function LiveDevelopment(require, exports, module) { | |||
| status = STATUS_ACTIVE; | |||
|
|
|||
| _openDocument(doc, editor); | |||
| if (doc.isDirty && _isHTMLDocument(doc)) { | |||
| var DocClass = _classForDocument(doc); | |||
There was a problem hiding this comment.
Naming nit: DocClass should start with a lower-case "D" - docClass. This is true for the other two instances below.
There was a problem hiding this comment.
Good catch! I was not thinking carefully when I copied it from an existing one.
|
Initial review complete. |
|
Done with your suggested changes. |
|
Looks good! Merging. |
gruehle
added a commit
that referenced
this pull request
Oct 12, 2012
Update live preview icon for any document that does not have .css extens...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ion.
Also update it only if live preview is on.
This fixes issues #1814 and #1815