This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Changes related to files with special characters #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-work * 'master' of github.com:adobe/brackets: (22 commits) Fix parameter name error and add name to anonymous function. Code cleanup. Add OPEN_FILE string. Fix deferred bug in doOpenWithOptionalPath() Make sure doOpenWithOptionalPath() always returns a Deferred object. Fixes issue #21. Error dialogs for open/save Respond to review comments. Code review cleanup Add unlink tests. Make all tests async. Refactored brackets.js to make the boot sequence cleaner, and pulled out the file handling code into a separate file. Simplified KeyBindingManager. Changed $.Deferred() to new $.Deferred(). Renamed showDialog() to showModalDialog() Hooked up to HTML file save API Added another reject() case to doOpen() Trying different indentation style for Deferred callbacks Added clarifying comment in FILE_CLOSE command Made commands rely on $.Deferred() to handle asynchronicity, and updated logic of the open/save/close commands to take advantage of this. Added dialog when closing dirty file. Refactored dialog code to make it more generic, driven by HTML. Added basic keymapping functions. Implementing file close--prompting to save not yet implemented Beginning implementation of prompt when closing dirty file Added comments around our dirty bit management ...
…r is encountered calling stat on a single file
…ackets.fs.readdir
…o-work * 'master' of github.com:adobe/brackets: Add the jstree.create listener before calling create Remove project loading from FileCommandHandler tests. Fix error handling for FILE_OPEN. Omit FileCommandHandlers-test when running with jasmine.sh. Fix merge conflicts in FileCommandHandlers. Hook up escape key handling to File > New. Respond to review comments. Minor code cleanup. Implement File > New. FileCommandHandlers tests for open, close, save commands and isDirty() status. Add .gitignore file to ignore Thumbs.db files, making 'git status' less noisy on Windows. We can easily add to this file to exclude additional types of OS-generated / cruft files later. Plumbing for File > New command. Discussed with NJ remaining tasks for 4.5 Changed file command tests to work with window.opener (so they'll only work when run from the main app), added open file test Forgot to add these files Trying jasmine UI testing, not ready for anything
gruehle
added a commit
that referenced
this pull request
Dec 20, 2011
Changes related to files with special characters
dancingfrog
pushed a commit
to Real-Currents/brackets
that referenced
this pull request
Mar 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request must be merged at the same time as the pull request for the fixIssue16 branch on adobe/brackets-app
Changes: