This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
File > Open results in runtime error #21
Comments
gruehle
added a commit
that referenced
this issue
Dec 19, 2011
tvoliter
added a commit
that referenced
this issue
Dec 19, 2011
…o-work * 'master' of github.com:adobe/brackets: (22 commits) Fix parameter name error and add name to anonymous function. Code cleanup. Add OPEN_FILE string. Fix deferred bug in doOpenWithOptionalPath() Make sure doOpenWithOptionalPath() always returns a Deferred object. Fixes issue #21. Error dialogs for open/save Respond to review comments. Code review cleanup Add unlink tests. Make all tests async. Refactored brackets.js to make the boot sequence cleaner, and pulled out the file handling code into a separate file. Simplified KeyBindingManager. Changed $.Deferred() to new $.Deferred(). Renamed showDialog() to showModalDialog() Hooked up to HTML file save API Added another reject() case to doOpen() Trying different indentation style for Deferred callbacks Added clarifying comment in FILE_CLOSE command Made commands rely on $.Deferred() to handle asynchronicity, and updated logic of the open/save/close commands to take advantage of this. Added dialog when closing dirty file. Refactored dialog code to make it more generic, driven by HTML. Added basic keymapping functions. Implementing file close--prompting to save not yet implemented Beginning implementation of prompt when closing dirty file Added comments around our dirty bit management ...
peterflynn
added a commit
that referenced
this issue
Dec 19, 2011
* 'master' of github.com:adobe/brackets: (66 commits) Fix parameter name error and add name to anonymous function. Code cleanup. Add OPEN_FILE string. Fix deferred bug in doOpenWithOptionalPath() Make sure doOpenWithOptionalPath() always returns a Deferred object. Fixes issue #21. Error dialogs for open/save Respond to review comments. Code review cleanup Add unlink tests. Make all tests async. Fix getFile() error handling logic Refactored brackets.js to make the boot sequence cleaner, and pulled out the file handling code into a separate file. Simplified KeyBindingManager. Changed $.Deferred() to new $.Deferred(). Merge in latest CodeMirror Renamed showDialog() to showModalDialog() Fix getFile() error when path is a directory. More getFile() error handling unit tests. Use fs.unlink() to remove files created during unit tests. Hooked up to HTML file save API Code review from NJ. Move private members out of prototype to constructor. Added another reject() case to doOpen() Trying different indentation style for Deferred callbacks Fix _FileWriter event handling _FileWriter bug fixes ...
yofreke
added a commit
to jsio-private/brackets
that referenced
this issue
Jul 2, 2015
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to repro:
Results:
Runtime error reported in console
The text was updated successfully, but these errors were encountered: