This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed: Issue 2509 Double-clicking in rename input acts like double-clicking file normally #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| * @return boolean true if an input field is present | ||
| */ | ||
| function isInRename(event) { | ||
| return ($(event.target).closest("li").find("input").length === 0); |
There was a problem hiding this comment.
The logic got reversed. You want to check length > 0, right?
|
Done with review. |
|
@redmunds ready for final review |
|
Looks good. Merging. Thank you. |
redmunds
added a commit
that referenced
this pull request
Feb 8, 2013
Fixed: Issue 2509 Double-clicking in rename input acts like double-clicking file normally
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2509
@redmunds i opened up a new pull