Extracted default menus into extra file #2940

Merged
merged 3 commits into from Feb 28, 2013

Projects

None yet

2 participants

@WebsiteDeveloper
Contributor

No description provided.

@gruehle gruehle was assigned Feb 25, 2013
@gruehle gruehle commented on an outdated diff Feb 28, 2013
src/command/DefaultMenus.js
+ menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION);
+ menu.addMenuItem(Commands.NAVIGATE_GOTO_JSLINT_ERROR);
+ menu.addMenuDivider();
+ menu.addMenuItem(Commands.NAVIGATE_NEXT_DOC);
+ menu.addMenuItem(Commands.NAVIGATE_PREV_DOC);
+ menu.addMenuDivider();
+ menu.addMenuItem(Commands.NAVIGATE_SHOW_IN_FILE_TREE);
+ menu.addMenuDivider();
+ menu.addMenuItem(Commands.TOGGLE_QUICK_EDIT);
+ menu.addMenuItem(Commands.QUICK_EDIT_PREV_MATCH);
+ menu.addMenuItem(Commands.QUICK_EDIT_NEXT_MATCH);
+
+ /*
+ * Debug menu
+ */
+ if (brackets.config.show_debug_menu) {
@gruehle
gruehle Feb 28, 2013 Member

The debug menu items are now handled by an extension. This is probably why the pull request can't be merged as-is.

@gruehle gruehle commented on an outdated diff Feb 28, 2013
src/command/DefaultMenus.js
+
+
+/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50, regexp: true */
+/*global define, $, brackets, window */
+
+/**
+ * Initializes the default brackets menu items.
+ */
+define(function (require, exports, module) {
+ "use strict";
+
+ var AppInit = require("utils/AppInit"),
+ Commands = require("command/Commands"),
+ EditorManager = require("editor/EditorManager"),
+ Menus = require("command/Menus"),
+ Strings = require("strings");
@gruehle
gruehle Feb 28, 2013 Member

Minor style nit: please align the "=" signs

@gruehle
Member
gruehle commented Feb 28, 2013

@WebsiteDeveloper - thanks for separating this from the other pull request. The debug menu has been moved out into an extension, which is probably why this pull request can't be merged as-is. Please merge with master.

@WebsiteDeveloper
Contributor

@gruehle i merged with current master so should work fine

@gruehle
Member
gruehle commented Feb 28, 2013

@WebsiteDeveloper - looks great. Thanks!

@gruehle gruehle merged commit 96cdc87 into adobe:master Feb 28, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment