This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Extracted default menus into extra file #2940
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,298 @@ | ||
/* | ||
* Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a | ||
* copy of this software and associated documentation files (the "Software"), | ||
* to deal in the Software without restriction, including without limitation | ||
* the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
* and/or sell copies of the Software, and to permit persons to whom the | ||
* Software is furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
* DEALINGS IN THE SOFTWARE. | ||
* | ||
*/ | ||
|
||
|
||
/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50, regexp: true */ | ||
/*global define, $, brackets, window */ | ||
|
||
/** | ||
* Initializes the default brackets menu items. | ||
*/ | ||
define(function (require, exports, module) { | ||
"use strict"; | ||
|
||
var AppInit = require("utils/AppInit"), | ||
Commands = require("command/Commands"), | ||
EditorManager = require("editor/EditorManager"), | ||
Menus = require("command/Menus"), | ||
Strings = require("strings"); | ||
|
||
AppInit.htmlReady(function () { | ||
/* | ||
* File menu | ||
*/ | ||
var menu; | ||
menu = Menus.addMenu(Strings.FILE_MENU, Menus.AppMenuBar.FILE_MENU); | ||
menu.addMenuItem(Commands.FILE_NEW); | ||
menu.addMenuItem(Commands.FILE_NEW_FOLDER); | ||
menu.addMenuItem(Commands.FILE_OPEN); | ||
menu.addMenuItem(Commands.FILE_OPEN_FOLDER); | ||
menu.addMenuItem(Commands.FILE_CLOSE); | ||
menu.addMenuItem(Commands.FILE_CLOSE_ALL); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.FILE_SAVE); | ||
menu.addMenuItem(Commands.FILE_SAVE_ALL); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.FILE_LIVE_FILE_PREVIEW); | ||
menu.addMenuItem(Commands.FILE_LIVE_HIGHLIGHT); | ||
menu.addMenuItem(Commands.FILE_PROJECT_SETTINGS); | ||
|
||
// supress redundant quit menu item on mac | ||
if (brackets.platform !== "mac" && !brackets.inBrowser) { | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.FILE_QUIT); | ||
} | ||
|
||
/* | ||
* Edit menu | ||
*/ | ||
menu = Menus.addMenu(Strings.EDIT_MENU, Menus.AppMenuBar.EDIT_MENU); | ||
menu.addMenuItem(Commands.EDIT_UNDO); | ||
menu.addMenuItem(Commands.EDIT_REDO); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_CUT); | ||
menu.addMenuItem(Commands.EDIT_COPY); | ||
menu.addMenuItem(Commands.EDIT_PASTE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_SELECT_ALL); | ||
menu.addMenuItem(Commands.EDIT_SELECT_LINE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_FIND); | ||
menu.addMenuItem(Commands.EDIT_FIND_IN_FILES); | ||
menu.addMenuItem(Commands.EDIT_FIND_NEXT); | ||
|
||
menu.addMenuItem(Commands.EDIT_FIND_PREVIOUS); | ||
|
||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_REPLACE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_INDENT); | ||
menu.addMenuItem(Commands.EDIT_UNINDENT); | ||
menu.addMenuItem(Commands.EDIT_DUPLICATE); | ||
menu.addMenuItem(Commands.EDIT_DELETE_LINES); | ||
menu.addMenuItem(Commands.EDIT_LINE_UP); | ||
menu.addMenuItem(Commands.EDIT_LINE_DOWN); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.EDIT_LINE_COMMENT); | ||
menu.addMenuItem(Commands.EDIT_BLOCK_COMMENT); | ||
|
||
/* | ||
* View menu | ||
*/ | ||
menu = Menus.addMenu(Strings.VIEW_MENU, Menus.AppMenuBar.VIEW_MENU); | ||
menu.addMenuItem(Commands.VIEW_HIDE_SIDEBAR); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.VIEW_INCREASE_FONT_SIZE); | ||
menu.addMenuItem(Commands.VIEW_DECREASE_FONT_SIZE); | ||
menu.addMenuItem(Commands.VIEW_RESTORE_FONT_SIZE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.TOGGLE_JSLINT); | ||
|
||
/* | ||
* Navigate menu | ||
*/ | ||
menu = Menus.addMenu(Strings.NAVIGATE_MENU, Menus.AppMenuBar.NAVIGATE_MENU); | ||
menu.addMenuItem(Commands.NAVIGATE_QUICK_OPEN); | ||
menu.addMenuItem(Commands.NAVIGATE_GOTO_LINE); | ||
|
||
menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION); | ||
menu.addMenuItem(Commands.NAVIGATE_GOTO_JSLINT_ERROR); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.NAVIGATE_NEXT_DOC); | ||
menu.addMenuItem(Commands.NAVIGATE_PREV_DOC); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.NAVIGATE_SHOW_IN_FILE_TREE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.TOGGLE_QUICK_EDIT); | ||
menu.addMenuItem(Commands.QUICK_EDIT_PREV_MATCH); | ||
menu.addMenuItem(Commands.QUICK_EDIT_NEXT_MATCH); | ||
|
||
/* | ||
* Debug menu | ||
*/ | ||
if (brackets.config.show_debug_menu) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The debug menu items are now handled by an extension. This is probably why the pull request can't be merged as-is. |
||
menu = Menus.addMenu(Strings.DEBUG_MENU, Menus.AppMenuBar.DEBUG_MENU); | ||
menu.addMenuItem(Commands.DEBUG_SHOW_DEVELOPER_TOOLS); | ||
menu.addMenuItem(Commands.DEBUG_REFRESH_WINDOW); | ||
menu.addMenuItem(Commands.DEBUG_NEW_BRACKETS_WINDOW); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.DEBUG_SWITCH_LANGUAGE); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.DEBUG_RUN_UNIT_TESTS); | ||
menu.addMenuItem(Commands.DEBUG_SHOW_PERF_DATA); | ||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.DEBUG_ENABLE_NODE_DEBUGGER); | ||
menu.addMenuItem(Commands.DEBUG_LOG_NODE_STATE); | ||
menu.addMenuItem(Commands.DEBUG_RESTART_NODE); | ||
} | ||
|
||
/* | ||
* Help menu | ||
*/ | ||
menu = Menus.addMenu(Strings.HELP_MENU, Menus.AppMenuBar.HELP_MENU); | ||
menu.addMenuItem(Commands.HELP_CHECK_FOR_UPDATE); | ||
|
||
menu.addMenuDivider(); | ||
if (brackets.config.how_to_use_url) { | ||
menu.addMenuItem(Commands.HELP_HOW_TO_USE_BRACKETS); | ||
} | ||
if (brackets.config.forum_url) { | ||
menu.addMenuItem(Commands.HELP_FORUM); | ||
} | ||
if (brackets.config.release_notes_url) { | ||
menu.addMenuItem(Commands.HELP_RELEASE_NOTES); | ||
} | ||
if (brackets.config.report_issue_url) { | ||
menu.addMenuItem(Commands.HELP_REPORT_AN_ISSUE); | ||
} | ||
|
||
menu.addMenuDivider(); | ||
menu.addMenuItem(Commands.HELP_SHOW_EXT_FOLDER); | ||
|
||
|
||
var hasAboutItem = (brackets.platform !== "mac" || brackets.inBrowser); | ||
|
||
// Add final divider only if we have a twitter URL or about item | ||
if (hasAboutItem || brackets.config.twitter_url) { | ||
menu.addMenuDivider(); | ||
} | ||
|
||
if (brackets.config.twitter_url) { | ||
menu.addMenuItem(Commands.HELP_TWITTER); | ||
} | ||
// supress redundant about menu item in mac shell | ||
if (hasAboutItem) { | ||
menu.addMenuItem(Commands.HELP_ABOUT); | ||
} | ||
|
||
/* | ||
* Context Menus | ||
*/ | ||
var project_cmenu = Menus.registerContextMenu(Menus.ContextMenuIds.PROJECT_MENU); | ||
project_cmenu.addMenuItem(Commands.FILE_NEW); | ||
project_cmenu.addMenuItem(Commands.FILE_NEW_FOLDER); | ||
project_cmenu.addMenuItem(Commands.FILE_RENAME); | ||
project_cmenu.addMenuDivider(); | ||
project_cmenu.addMenuItem(Commands.EDIT_FIND_IN_SUBTREE); | ||
|
||
var working_set_cmenu = Menus.registerContextMenu(Menus.ContextMenuIds.WORKING_SET_MENU); | ||
working_set_cmenu.addMenuItem(Commands.FILE_CLOSE); | ||
working_set_cmenu.addMenuItem(Commands.FILE_SAVE); | ||
working_set_cmenu.addMenuItem(Commands.FILE_RENAME); | ||
working_set_cmenu.addMenuItem(Commands.NAVIGATE_SHOW_IN_FILE_TREE); | ||
working_set_cmenu.addMenuDivider(); | ||
working_set_cmenu.addMenuItem(Commands.EDIT_FIND_IN_SUBTREE); | ||
working_set_cmenu.addMenuDivider(); | ||
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_ADDED); | ||
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_NAME); | ||
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_TYPE); | ||
working_set_cmenu.addMenuDivider(); | ||
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_AUTO); | ||
|
||
var editor_cmenu = Menus.registerContextMenu(Menus.ContextMenuIds.EDITOR_MENU); | ||
editor_cmenu.addMenuItem(Commands.TOGGLE_QUICK_EDIT); | ||
editor_cmenu.addMenuItem(Commands.EDIT_SELECT_ALL); | ||
|
||
var inline_editor_cmenu = Menus.registerContextMenu(Menus.ContextMenuIds.INLINE_EDITOR_MENU); | ||
inline_editor_cmenu.addMenuItem(Commands.TOGGLE_QUICK_EDIT); | ||
inline_editor_cmenu.addMenuItem(Commands.EDIT_SELECT_ALL); | ||
inline_editor_cmenu.addMenuDivider(); | ||
inline_editor_cmenu.addMenuItem(Commands.QUICK_EDIT_PREV_MATCH); | ||
inline_editor_cmenu.addMenuItem(Commands.QUICK_EDIT_NEXT_MATCH); | ||
|
||
/** | ||
* Context menu for code editors (both full-size and inline) | ||
* Auto selects the word the user clicks if the click does not occur over | ||
* an existing selection | ||
*/ | ||
$("#editor-holder").on("contextmenu", function (e) { | ||
if ($(e.target).parents(".CodeMirror-gutter").length !== 0) { | ||
return; | ||
} | ||
|
||
// Note: on mousedown before this event, CodeMirror automatically checks mouse pos, and | ||
// if not clicking on a selection moves the cursor to click location. When triggered | ||
// from keyboard, no pre-processing occurs and the cursor/selection is left as is. | ||
|
||
var editor = EditorManager.getFocusedEditor(), | ||
inlineWidget = EditorManager.getFocusedInlineWidget(); | ||
|
||
if (editor) { | ||
// If there's just an insertion point select the word token at the cursor pos so | ||
// it's more clear what the context menu applies to. | ||
if (!editor.hasSelection()) { | ||
editor.selectWordAt(editor.getCursorPos()); | ||
|
||
// Prevent menu from overlapping text by moving it down a little | ||
// Temporarily backout this change for now to help mitigate issue #1111, | ||
// which only happens if mouse is not over context menu. Better fix | ||
// requires change to bootstrap, which is too risky for now. | ||
//e.pageY += 6; | ||
} | ||
|
||
// Inline text editors have a different context menu (safe to assume it's not some other | ||
// type of inline widget since we already know an Editor has focus) | ||
if (inlineWidget) { | ||
inline_editor_cmenu.open(e); | ||
} else { | ||
editor_cmenu.open(e); | ||
} | ||
} | ||
}); | ||
|
||
/** | ||
* Context menus for folder tree & working set list | ||
*/ | ||
$("#project-files-container").on("contextmenu", function (e) { | ||
project_cmenu.open(e); | ||
}); | ||
|
||
$("#open-files-container").on("contextmenu", function (e) { | ||
working_set_cmenu.open(e); | ||
}); | ||
|
||
// Prevent the browser context menu since Brackets creates a custom context menu | ||
$(window).contextmenu(function (e) { | ||
e.preventDefault(); | ||
}); | ||
|
||
/* | ||
* General menu event processing | ||
*/ | ||
// Prevent clicks on top level menus and menu items from taking focus | ||
$(window.document).on("mousedown", ".dropdown", function (e) { | ||
e.preventDefault(); | ||
}); | ||
|
||
// Switch menus when the mouse enters an adjacent menu | ||
// Only open the menu if another one has already been opened | ||
// by clicking | ||
$(window.document).on("mouseenter", "#main-toolbar .dropdown", function (e) { | ||
var open = $(this).siblings(".open"); | ||
if (open.length > 0) { | ||
open.removeClass("open"); | ||
$(this).addClass("open"); | ||
} | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style nit: please align the "=" signs